Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Unified Diff: pkg/polymer_expressions/lib/eval.dart

Issue 23458017: Add null literals to polymer expressions (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/polymer_expressions/lib/parser.dart » ('j') | pkg/polymer_expressions/test/eval_test.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/polymer_expressions/lib/eval.dart
diff --git a/pkg/polymer_expressions/lib/eval.dart b/pkg/polymer_expressions/lib/eval.dart
index 7ed7b5a5afb9ec4364b662554ec9695cb4cf9444..9d9f8ef8f5d5ccb30d883cdea4c0a08fe4ce7c07 100644
--- a/pkg/polymer_expressions/lib/eval.dart
+++ b/pkg/polymer_expressions/lib/eval.dart
@@ -469,9 +469,12 @@ class BinaryObserver extends ExpressionObserver<BinaryOperator>
var f = _BINARY_OPERATORS[operator];
if (operator == '&&' || operator == '||') {
_value = f(_toBool(left._value), _toBool(right._value));
+ } else if (operator == '==' || operator == '!=') {
+ _value = f(left._value, right._value);
+ } else if (left._value == null || right._value == null) {
+ _value = null;
} else {
- _value = (left._value == null || right._value == null)
- ? null : f(left._value, right._value);
+ _value = f(left._value, right._value);
}
}
« no previous file with comments | « no previous file | pkg/polymer_expressions/lib/parser.dart » ('j') | pkg/polymer_expressions/test/eval_test.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698