Include viewport clip in visible rect of unclipped surfaces (2)

Include viewport clip in visible rect of unclipped surfaces (2)

BUG=642054
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/94bebdd533d8052df7cb12228096e814680afb4c
Cr-Commit-Position: refs/heads/master@{#419294}

[jaydasika, 2016-09-16 01:10:31]

Description was changed from

==========
Include viewport clip in visible rect of unclipped surfaces (2)

BUG=642054
==========

to

==========
Include viewport clip in visible rect of unclipped surfaces (2)

BUG=642054
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[jaydasika, 2016-09-16 01:20:48]

The CQ bit was checked by jaydasika@chromium.org to run a CQ dry run

[jaydasika, 2016-09-16 01:21:07]

jaydasika@chromium.org changed reviewers:
+ ajuma@chromium.org, weiliangc@chromium.org

[jaydasika, 2016-09-16 01:21:08]

PTAL

https://codereview.chromium.org/2345793003/diff/20001/cc/trees/layer_tree_hos...
File cc/trees/layer_tree_host_common_unittest.cc (right):

https://codereview.chromium.org/2345793003/diff/20001/cc/trees/layer_tree_hos...
cc/trees/layer_tree_host_common_unittest.cc:5610: EXPECT_EQ(gfx::Rect(10, 0, 40,
30), surface_child->visible_layer_rect());
This test was added in https://codereview.chromium.org/19734014/ for copy
requests. We now have other tests for it. So, I think this can be deleted. WDYT
?

[commit-bot: I haz the power, 2016-09-16 01:21:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 01:32:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 01:32:17]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[jaydasika, 2016-09-16 19:30:16]

The CQ bit was checked by jaydasika@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 19:30:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 19:44:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 19:44:35]

Dry run: This issue passed the CQ dry run.

[weiliangc, 2016-09-16 20:07:11]

LGTM

https://codereview.chromium.org/2345793003/diff/20001/cc/trees/layer_tree_hos...
File cc/trees/layer_tree_host_common_unittest.cc (right):

https://codereview.chromium.org/2345793003/diff/20001/cc/trees/layer_tree_hos...
cc/trees/layer_tree_host_common_unittest.cc:5610: EXPECT_EQ(gfx::Rect(10, 0, 40,
30), surface_child->visible_layer_rect());
On 2016/09/16 at 01:21:08, jaydasika wrote:
> This test was added in https://codereview.chromium.org/19734014/ for copy
requests. We now have other tests for it. So, I think this can be deleted. WDYT
?

Sounds good. From description this is added for copy request.

[jaydasika, 2016-09-16 21:04:57]

The CQ bit was checked by jaydasika@chromium.org

[jaydasika, 2016-09-16 21:04:57]

The patchset sent to the CQ was uploaded after l-g-t-m from
weiliangc@chromium.org
Link to the patchset: https://codereview.chromium.org/2345793003/#ps40001
(title: "delete test")

[commit-bot: I haz the power, 2016-09-16 21:05:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 22:11:40]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-16 22:15:07]

Description was changed from

==========
Include viewport clip in visible rect of unclipped surfaces (2)

BUG=642054
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Include viewport clip in visible rect of unclipped surfaces (2)

BUG=642054
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/94bebdd533d8052df7cb12228096e814680afb4c
Cr-Commit-Position: refs/heads/master@{#419294}
==========

[commit-bot: I haz the power, 2016-09-16 22:15:09]

Patchset 3 (id:??) landed as
https://crrev.com/94bebdd533d8052df7cb12228096e814680afb4c
Cr-Commit-Position: refs/heads/master@{#419294}