Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 2345793002: Stop generating index information for SDK and simplify summary generation. (Closed)

Created:
4 years, 3 months ago by scheglov
Modified:
4 years, 3 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Stop generating index information for SDK and simplify summary generation. The implementation is still element model based, I will switch it to the AST based approach in a following CL. R=paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/fa24d1caaa9ef1282ce3ce0a2a1179bc4ba35297

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -295 lines) Patch
M pkg/analyzer/lib/src/summary/summary_file_builder.dart View 4 chunks +19 lines, -147 lines 0 comments Download
M pkg/analyzer/tool/summary/build_sdk_summaries.dart View 2 chunks +39 lines, -125 lines 0 comments Download
M pkg/analyzer_cli/pubspec.yaml View 1 chunk +3 lines, -0 lines 2 comments Download
M utils/dartanalyzer/dartanalyzer.gyp View 3 chunks +8 lines, -23 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
4 years, 3 months ago (2016-09-15 20:22:56 UTC) #1
Paul Berry
lgtm https://codereview.chromium.org/2345793002/diff/1/pkg/analyzer_cli/pubspec.yaml File pkg/analyzer_cli/pubspec.yaml (right): https://codereview.chromium.org/2345793002/diff/1/pkg/analyzer_cli/pubspec.yaml#newcode22 pkg/analyzer_cli/pubspec.yaml:22: dependency_overrides: Was this an intentional change? My recollection ...
4 years, 3 months ago (2016-09-15 22:10:01 UTC) #2
scheglov
https://codereview.chromium.org/2345793002/diff/1/pkg/analyzer_cli/pubspec.yaml File pkg/analyzer_cli/pubspec.yaml (right): https://codereview.chromium.org/2345793002/diff/1/pkg/analyzer_cli/pubspec.yaml#newcode22 pkg/analyzer_cli/pubspec.yaml:22: dependency_overrides: On 2016/09/15 22:10:01, Paul Berry wrote: > Was ...
4 years, 3 months ago (2016-09-15 23:14:53 UTC) #3
scheglov
4 years, 3 months ago (2016-09-15 23:15:27 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
fa24d1caaa9ef1282ce3ce0a2a1179bc4ba35297 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698