Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 2345783002: Added some basic WebVR use counters (Closed)

Created:
4 years, 3 months ago by bajones
Modified:
4 years, 3 months ago
Reviewers:
haraken, Mike West, Mark P
CC:
asvitkine+watch_chromium.org, blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added some basic WebVR use counters Tracking how many pages query for VR hardware, how many actually pesent anything to that hardware, and how many use a deprecated function call. BUG=389343 Committed: https://crrev.com/b79b06ddf6ebbe947b820f3d59d6a6cede5d5223 Cr-Commit-Position: refs/heads/master@{#419114}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/vr/NavigatorVR.cpp View 2 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/vr/VRDisplay.cpp View 3 chunks +9 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
bajones
mpearson@: Review histograms.xml please? haraken@: core/ and source/ please?
4 years, 3 months ago (2016-09-15 20:05:38 UTC) #3
Mark P
histograms.xml lgtm
4 years, 3 months ago (2016-09-15 21:54:43 UTC) #4
haraken
modules/ LGTM
4 years, 3 months ago (2016-09-16 01:51:19 UTC) #5
bajones
mkwst@chromium.org: Please review changes in UseCounter.h
4 years, 3 months ago (2016-09-16 03:30:39 UTC) #7
Mike West
LGTM
4 years, 3 months ago (2016-09-16 05:05:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2345783002/1
4 years, 3 months ago (2016-09-16 05:06:30 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-16 06:46:57 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 06:50:00 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b79b06ddf6ebbe947b820f3d59d6a6cede5d5223
Cr-Commit-Position: refs/heads/master@{#419114}

Powered by Google App Engine
This is Rietveld 408576698