Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 2345773003: Use declared variables to select the correct configuration for resolution (Closed)

Created:
4 years, 3 months ago by Brian Wilkerson
Modified:
4 years, 3 months ago
Reviewers:
Paul Berry, scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use declared variables to select the correct configuration for resolution R=paulberry@google.com, scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/22040876bf78d8a13294990d198b48109b70473e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+361 lines, -84 lines) Patch
M pkg/analysis_server/lib/src/services/correction/fix_internal.dart View 3 chunks +7 lines, -3 lines 0 comments Download
M pkg/analysis_server/lib/src/status/ast_writer.dart View 4 chunks +7 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/context/declared_variables.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/dart/ast/ast.dart View 4 chunks +34 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/src/dart/ast/ast.dart View 7 chunks +51 lines, -16 lines 0 comments Download
M pkg/analyzer/lib/src/dart/ast/utilities.dart View 6 chunks +8 lines, -5 lines 0 comments Download
M pkg/analyzer/lib/src/dart/element/builder.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/task/dart.dart View 10 chunks +120 lines, -49 lines 0 comments Download
M pkg/analyzer/lib/src/task/incremental_element_builder.dart View 5 chunks +9 lines, -1 line 0 comments Download
M pkg/analyzer/test/src/context/context_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/src/task/dart_test.dart View 2 chunks +116 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Brian Wilkerson
This is a possible alternative to the CL Konstantin put out.
4 years, 3 months ago (2016-09-15 21:27:17 UTC) #2
Paul Berry
lgtm
4 years, 3 months ago (2016-09-15 22:24:50 UTC) #3
scheglov
lgtm
4 years, 3 months ago (2016-09-15 23:27:33 UTC) #4
Brian Wilkerson
4 years, 3 months ago (2016-09-16 14:32:43 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
22040876bf78d8a13294990d198b48109b70473e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698