Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2345773002:
[MR UI] Handle fractional height for first-run-flow element (Closed)
Description[MR UI] Handle fractional height for first-run-flow element
The first run flow div, whose height is not hard-coded, has a fractional height value, which is also used as the top margin size for the header below it. By keeping it fractional rather than rounding by using offsetHeight, we avoid rounding errors.
BUG=615373
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/99ee961ad19a96ba4fa47a92130aee1e3f0dc0db
Cr-Commit-Position: refs/heads/master@{#419213}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Modify a comment #Messages
Total messages: 18 (11 generated)
Description was changed from ========== . BUG= ========== to ========== . BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== . BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== [MR UI] Handle fractional height for first-run-flow element BUG=615373 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== [MR UI] Handle fractional height for first-run-flow element BUG=615373 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== [MR UI] Handle fractional height for first-run-flow element The first run flow div has fractional height value, which is also used as the top margin size for the header below it. By keeping it fractional rather than rounding by using offsetHeight, we avoid rounding errors. BUG=615373 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== [MR UI] Handle fractional height for first-run-flow element The first run flow div has fractional height value, which is also used as the top margin size for the header below it. By keeping it fractional rather than rounding by using offsetHeight, we avoid rounding errors. BUG=615373 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== [MR UI] Handle fractional height for first-run-flow element The first run flow div has a fractional height value, which is also used as the top margin size for the header below it. By keeping it fractional rather than rounding by using offsetHeight, we avoid rounding errors. BUG=615373 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== [MR UI] Handle fractional height for first-run-flow element The first run flow div has a fractional height value, which is also used as the top margin size for the header below it. By keeping it fractional rather than rounding by using offsetHeight, we avoid rounding errors. BUG=615373 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== [MR UI] Handle fractional height for first-run-flow element The first run flow div, whose height is not hard-coded, has a fractional height value, which is also used as the top margin size for the header below it. By keeping it fractional rather than rounding by using offsetHeight, we avoid rounding errors. BUG=615373 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
takumif@chromium.org changed reviewers: + apacible@chromium.org
Please take a look, thank you!
lgtm https://codereview.chromium.org/2345773002/diff/1/chrome/browser/resources/me... File chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js (right): https://codereview.chromium.org/2345773002/diff/1/chrome/browser/resources/me... chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js:2321: // getBoundingClientRect() to avoid rounding errors. nit: add a comment explaining why this distinction is important for frf and not the other elements.
lgtm lgtm https://codereview.chromium.org/2345773002/diff/1/chrome/browser/resources/me... File chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js (right): https://codereview.chromium.org/2345773002/diff/1/chrome/browser/resources/me... chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js:2321: // getBoundingClientRect() to avoid rounding errors. nit: add a comment explaining why this distinction is important for frf and not the other elements.
Patchset #2 (id:20001) has been deleted
https://codereview.chromium.org/2345773002/diff/1/chrome/browser/resources/me... File chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js (right): https://codereview.chromium.org/2345773002/diff/1/chrome/browser/resources/me... chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js:2321: // getBoundingClientRect() to avoid rounding errors. On 2016/09/16 04:50:51, apacible wrote: > nit: add a comment explaining why this distinction is important for frf and not > the other elements. Done.
The CQ bit was checked by takumif@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from apacible@chromium.org Link to the patchset: https://codereview.chromium.org/2345773002/#ps40001 (title: "Modify a comment")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [MR UI] Handle fractional height for first-run-flow element The first run flow div, whose height is not hard-coded, has a fractional height value, which is also used as the top margin size for the header below it. By keeping it fractional rather than rounding by using offsetHeight, we avoid rounding errors. BUG=615373 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== [MR UI] Handle fractional height for first-run-flow element The first run flow div, whose height is not hard-coded, has a fractional height value, which is also used as the top margin size for the header below it. By keeping it fractional rather than rounding by using offsetHeight, we avoid rounding errors. BUG=615373 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== [MR UI] Handle fractional height for first-run-flow element The first run flow div, whose height is not hard-coded, has a fractional height value, which is also used as the top margin size for the header below it. By keeping it fractional rather than rounding by using offsetHeight, we avoid rounding errors. BUG=615373 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== [MR UI] Handle fractional height for first-run-flow element The first run flow div, whose height is not hard-coded, has a fractional height value, which is also used as the top margin size for the header below it. By keeping it fractional rather than rounding by using offsetHeight, we avoid rounding errors. BUG=615373 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/99ee961ad19a96ba4fa47a92130aee1e3f0dc0db Cr-Commit-Position: refs/heads/master@{#419213} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/99ee961ad19a96ba4fa47a92130aee1e3f0dc0db Cr-Commit-Position: refs/heads/master@{#419213} |
