Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 2345743002: AbstractDartSdk should not return its linked bundle if 'useSummary' is false. (Closed)

Created:
4 years, 3 months ago by scheglov
Modified:
4 years, 3 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

AbstractDartSdk should not return its linked bundle if 'useSummary' is false. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/37a36f03890cd81ea2a06d1323a1b08e04c9e7dd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M pkg/analyzer/lib/src/dart/sdk/sdk.dart View 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 3 months ago (2016-09-15 18:23:31 UTC) #1
Brian Wilkerson
lgtm
4 years, 3 months ago (2016-09-15 18:29:01 UTC) #2
scheglov
4 years, 3 months ago (2016-09-15 18:37:15 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
37a36f03890cd81ea2a06d1323a1b08e04c9e7dd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698