Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Issue 234573005: Clean up the public interface of Map. (Closed)

Created:
6 years, 8 months ago by Toon Verwaest
Modified:
6 years, 8 months ago
Reviewers:
mvstanton
CC:
v8-dev
Visibility:
Public.

Description

Clean up the public interface of Map. BUG= R=mvstanton@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20716

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -102 lines) Patch
M src/objects.h View 1 9 chunks +57 lines, -55 lines 0 comments Download
M src/objects.cc View 1 16 chunks +30 lines, -25 lines 0 comments Download
M src/objects-inl.h View 2 chunks +0 lines, -18 lines 0 comments Download
M test/cctest/test-heap.cc View 1 2 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Toon Verwaest
PTAL
6 years, 8 months ago (2014-04-11 14:05:07 UTC) #1
mvstanton
LGTM.
6 years, 8 months ago (2014-04-14 11:15:05 UTC) #2
Toon Verwaest
6 years, 8 months ago (2014-04-14 11:19:46 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r20716 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698