Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(517)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 234573003: Upstream PO2TS_IOS unit test. (Closed)

Created:
6 years, 8 months ago by msarda
Modified:
6 years, 5 months ago
Reviewers:
eddiejwilliams2014, HEATHERHONEY1976, bonejob300, blundell
CC:
chromium-reviews, Roger Tawa OOO till Jul 10th
Visibility:
Public.

Description

Upstream PO2TS_IOS unit test. BUG=NONE Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263249

Patch Set 1 #

Total comments: 2

Patch Set 2 : Nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+485 lines, -20 lines) Patch
M components/components_tests.gyp View 2 chunks +6 lines, -0 lines 0 comments Download
A components/signin/core/browser/DEPS View 1 chunk +6 lines, -0 lines 0 comments Download
M components/signin/core/browser/test_signin_client.h View 3 chunks +13 lines, -0 lines 0 comments Download
M components/signin/core/browser/test_signin_client.cc View 2 chunks +13 lines, -3 lines 0 comments Download
M components/signin/ios/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M components/signin/ios/browser/profile_oauth2_token_service_ios.h View 2 chunks +7 lines, -8 lines 0 comments Download
M components/signin/ios/browser/profile_oauth2_token_service_ios.mm View 2 chunks +2 lines, -0 lines 0 comments Download
A components/signin/ios/browser/profile_oauth2_token_service_ios_unittest.mm View 1 1 chunk +276 lines, -0 lines 0 comments Download
A + ios/ios_tests.gyp View 1 chunk +7 lines, -9 lines 0 comments Download
A ios/public/test/fake_profile_oauth2_token_service_ios_provider.h View 1 1 chunk +63 lines, -0 lines 0 comments Download
A ios/public/test/fake_profile_oauth2_token_service_ios_provider.mm View 1 1 chunk +91 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
msarda
Please take a look.
6 years, 8 months ago (2014-04-11 09:55:50 UTC) #1
msarda
6 years, 8 months ago (2014-04-11 10:59:38 UTC) #2
blundell
LGTM https://codereview.chromium.org/234573003/diff/1/ios/public/test/fake_profile_oauth2_token_service_ios_provider.mm File ios/public/test/fake_profile_oauth2_token_service_ios_provider.mm (right): https://codereview.chromium.org/234573003/diff/1/ios/public/test/fake_profile_oauth2_token_service_ios_provider.mm#newcode1 ios/public/test/fake_profile_oauth2_token_service_ios_provider.mm:1: // Copyright 2013 The Chromium Authors. All rights ...
6 years, 8 months ago (2014-04-11 11:19:16 UTC) #3
msarda
https://codereview.chromium.org/234573003/diff/1/ios/public/test/fake_profile_oauth2_token_service_ios_provider.mm File ios/public/test/fake_profile_oauth2_token_service_ios_provider.mm (right): https://codereview.chromium.org/234573003/diff/1/ios/public/test/fake_profile_oauth2_token_service_ios_provider.mm#newcode1 ios/public/test/fake_profile_oauth2_token_service_ios_provider.mm:1: // Copyright 2013 The Chromium Authors. All rights reserved. ...
6 years, 8 months ago (2014-04-11 11:25:05 UTC) #4
msarda
The CQ bit was checked by msarda@chromium.org
6 years, 8 months ago (2014-04-11 11:25:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msarda@chromium.org/234573003/20001
6 years, 8 months ago (2014-04-11 11:25:28 UTC) #6
commit-bot: I haz the power
Change committed as 263249
6 years, 8 months ago (2014-04-11 15:36:55 UTC) #7
eddiejwilliams2014
lgtm
6 years, 8 months ago (2014-04-24 04:07:43 UTC) #8
bonejob300_gmail.com
lgtm
6 years, 8 months ago (2014-04-25 21:47:54 UTC) #9
bonejob300_gmail.com
6 years, 8 months ago (2014-04-25 21:51:42 UTC) #10
HEATHERHONEY1976
6 years, 5 months ago (2014-06-27 08:16:04 UTC) #11
Message was sent while issue was closed. 
;-P

Powered by Google App Engine
This is Rietveld 408576698