Issue 23457004: roll gyp 1714:1716

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23457004: roll gyp 1714:1716 (Closed)

Created:
7 years, 3 months ago by Nico

Modified:
7 years, 3 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

roll gyp 1714:1716 1715: Tests: Try to set +x bot on new change.sh file, try 2. 1716: ninja&make/mac: Give loadable_modules type MH_BUNDLE. BUG=280718 TBR=mark@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221465

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	DEPS	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/23457004/1

7 years, 3 months ago (2013-09-05 15:53:29 UTC) #2

Nico

7 years, 3 months ago (2013-09-05 18:24:24 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r221465 (presubmit successful).