rollforward cr/2296923004 with fix: updated unittest to prevent issue with unreachable code (win_ch…

rollforward cr/2296923004 with fix: updated unittest to prevent issue with unreachable code (win_chromium)

BUG=635596
Committed: https://crrev.com/0d2564ebbee77202ded3b0d97d1406562c0cd1ea
Cr-Commit-Position: refs/heads/master@{#419212}

[panicker, 2016-09-16 01:22:51]

panicker@chromium.org changed reviewers:
+ dgozman@chromium.org

[panicker, 2016-09-16 01:22:52]

Rollforward with minor fix. PTAL

https://codereview.chromium.org/2345693004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/inspector/InspectorWebPerfAgentTest.cpp
(right):

https://codereview.chromium.org/2345693004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/InspectorWebPerfAgentTest.cpp:48:
Location* location = (*m_agent->m_frameContextLocations.begin()).get();
this is the only line that changed in rollforward.

[dgozman, 2016-09-16 01:35:49]

lgtm

For future reference, it's usually easier to upload patchset1 equal to original
patch and patchset2 being the new code (as opposite to uploading additional
patchset to previous CL).

[panicker, 2016-09-16 02:11:05]

The CQ bit was checked by panicker@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 02:11:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[panicker, 2016-09-16 02:11:47]

On 2016/09/16 01:35:49, dgozman wrote:
> lgtm
> 
> For future reference, it's usually easier to upload patchset1 equal to
original
> patch and patchset2 being the new code (as opposite to uploading additional
> patchset to previous CL).

Thanks for the tip. I'm still working out the chromium workflow.

[commit-bot: I haz the power, 2016-09-16 02:17:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 02:17:33]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[panicker, 2016-09-16 16:46:48]

The CQ bit was checked by panicker@chromium.org

[commit-bot: I haz the power, 2016-09-16 16:47:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 18:03:41]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-16 18:05:19]

Description was changed from

==========
rollforward cr/2296923004 with fix: updated unittest to prevent issue with
unreachable code (win_chromium)

BUG=635596
==========

to

==========
rollforward cr/2296923004 with fix: updated unittest to prevent issue with
unreachable code (win_chromium)

BUG=635596

Committed: https://crrev.com/0d2564ebbee77202ded3b0d97d1406562c0cd1ea
Cr-Commit-Position: refs/heads/master@{#419212}
==========

[commit-bot: I haz the power, 2016-09-16 18:05:21]

Patchset 1 (id:??) landed as
https://crrev.com/0d2564ebbee77202ded3b0d97d1406562c0cd1ea
Cr-Commit-Position: refs/heads/master@{#419212}