hongchan: PTAL tkent: Review as API owner; a very minor tweak to the API. The ...
4 years, 3 months ago
(2016-09-15 15:53:13 UTC)
#5
hongchan: PTAL
tkent: Review as API owner; a very minor tweak to the API. The only visible
change is that OfflineAudioContext.close() no longer exists, but all it ever did
was throw an error if used.
hongchan
lgtm
4 years, 3 months ago
(2016-09-15 16:18:15 UTC)
#6
lgtm
tkent
lgtm. A minor web-exposed change, and almost no risk.
4 years, 3 months ago
(2016-09-15 22:12:56 UTC)
#7
lgtm. A minor web-exposed change, and almost no risk.
Raymond Toy
The CQ bit was checked by rtoy@chromium.org
4 years, 3 months ago
(2016-09-15 22:25:52 UTC)
#8
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/294185)
4 years, 3 months ago
(2016-09-16 00:12:24 UTC)
#11
Issue 2345693002: Move close() from BaseAudioContext to AudioContext
(Closed)
Created 4 years, 3 months ago by Raymond Toy
Modified 4 years, 3 months ago
Reviewers: tkent, hongchan
Base URL:
Comments: 0