Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2345693002: Move close() from BaseAudioContext to AudioContext (Closed)

Created:
4 years, 3 months ago by Raymond Toy
Modified:
4 years, 3 months ago
Reviewers:
tkent, hongchan
CC:
blink-reviews, chromium-reviews, haraken, hongchan, Raymond Toy
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move close() from BaseAudioContext to AudioContext OfflineAudioContext cannot be closed so it makes more sense to have close() be defined on AudioContext instead of BaseAudioContext. This is a very minor tweak to the API, so no Blink intent submitted. Spec issue: https://github.com/WebAudio/web-audio-api/issues/948 Resolved: https://github.com/WebAudio/web-audio-api/issues/974 Chrome feature: https://www.chromestatus.com/feature/5683205155848192 BUG=647261 TEST=audiocontext-close.html Committed: https://crrev.com/afc2a8c12033ede8c9cedb501299e47270f75cb8 Cr-Commit-Position: refs/heads/master@{#419244}

Patch Set 1 #

Patch Set 2 : Tweak test. #

Patch Set 3 : Update expected results #

Messages

Total messages: 18 (10 generated)
Raymond Toy
hongchan: PTAL tkent: Review as API owner; a very minor tweak to the API. The ...
4 years, 3 months ago (2016-09-15 15:53:13 UTC) #5
hongchan
lgtm
4 years, 3 months ago (2016-09-15 16:18:15 UTC) #6
tkent
lgtm. A minor web-exposed change, and almost no risk.
4 years, 3 months ago (2016-09-15 22:12:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2345693002/20001
4 years, 3 months ago (2016-09-15 22:26:13 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/294185)
4 years, 3 months ago (2016-09-16 00:12:24 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2345693002/40001
4 years, 3 months ago (2016-09-16 17:43:35 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-16 19:19:54 UTC) #16
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 19:23:12 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/afc2a8c12033ede8c9cedb501299e47270f75cb8
Cr-Commit-Position: refs/heads/master@{#419244}

Powered by Google App Engine
This is Rietveld 408576698