Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(565)

Issue 2345673002: [NewTabPage] Refine fakebox scrolling transition on tablets. (Closed)

Created:
4 years, 3 months ago by PEConn
Modified:
4 years, 3 months ago
CC:
chromium-reviews, ntp-dev+reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NewTabPage] Refine fakebox scrolling transition on tablets. - Add the tab strip height factor into the transition equation to make sure the transition is anchored to the top of the tab. - Override ntp_search_box_transition_length to make the transition take longer on tablets. BUG=625145 Committed: https://crrev.com/c68e23208ff63d1e6562443618a5310883d0efae Cr-Commit-Position: refs/heads/master@{#419137}

Patch Set 1 #

Patch Set 2 : Adjust start distance. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M chrome/android/java/res/values-sw600dp/dimens.xml View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java View 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
PEConn
PTAL - I'm currently waiting for an OK from UX.
4 years, 3 months ago (2016-09-15 09:23:24 UTC) #3
Michael van Ouwerkerk
lgtm
4 years, 3 months ago (2016-09-15 09:30:18 UTC) #4
Bernhard Bauer
lgtm
4 years, 3 months ago (2016-09-15 10:31:11 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2345673002/40001
4 years, 3 months ago (2016-09-16 09:47:26 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 3 months ago (2016-09-16 10:23:26 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 10:24:59 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c68e23208ff63d1e6562443618a5310883d0efae
Cr-Commit-Position: refs/heads/master@{#419137}

Powered by Google App Engine
This is Rietveld 408576698