Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutTextTest.cpp

Issue 2345633007: Don't overflow in LayoutText::width() on a huge length. (Closed)
Patch Set: Tweak test ranges for Mac results. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutText.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/LayoutTextTest.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutTextTest.cpp b/third_party/WebKit/Source/core/layout/LayoutTextTest.cpp
new file mode 100644
index 0000000000000000000000000000000000000000..9c551bbcf4df3a69b7405733b165cb34ab898c3b
--- /dev/null
+++ b/third_party/WebKit/Source/core/layout/LayoutTextTest.cpp
@@ -0,0 +1,88 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "core/layout/LayoutText.h"
+
+#include "core/layout/LayoutTestHelper.h"
+#include "core/layout/line/InlineTextBox.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace blink {
+
+namespace {
+
+class LayoutTextTest : public RenderingTest {
+public:
+ void setBasicBody(const char* message)
+ {
+ setBodyInnerHTML(String::format("<div id='target' style='font-size: 10px;'>%s</div>", message));
+ }
+
+ LayoutText* getBasicText()
+ {
+ return toLayoutText(getLayoutObjectByElementId("target")->slowFirstChild());
+ }
+};
+
+const char* kTacoText = "Los Compadres Taco Truck";
+
+} // namespace
+
+TEST_F(LayoutTextTest, WidthZeroFromZeroLength)
+{
+ setBasicBody(kTacoText);
+ ASSERT_EQ(0, getBasicText()->width(0u, 0u, LayoutUnit(), LTR, false));
+}
+
+TEST_F(LayoutTextTest, WidthMaxFromZeroLength)
+{
+ setBasicBody(kTacoText);
+ ASSERT_EQ(0, getBasicText()->width(std::numeric_limits<unsigned>::max(), 0u, LayoutUnit(), LTR, false));
+}
+
+TEST_F(LayoutTextTest, WidthZeroFromMaxLength)
+{
+ setBasicBody(kTacoText);
+ float width = getBasicText()->width(0u, std::numeric_limits<unsigned>::max(), LayoutUnit(), LTR, false);
+ // Width may vary by platform and we just want to make sure it's something roughly reasonable.
+ ASSERT_GE(width, 100.f);
+ ASSERT_LE(width, 160.f);
+}
+
+TEST_F(LayoutTextTest, WidthMaxFromMaxLength)
+{
+ setBasicBody(kTacoText);
+ ASSERT_EQ(0, getBasicText()->width(std::numeric_limits<unsigned>::max(),
+ std::numeric_limits<unsigned>::max(), LayoutUnit(), LTR, false));
+}
+
+TEST_F(LayoutTextTest, WidthWithHugeLengthAvoidsOverflow)
+{
+ // The test case from http://crbug.com/647820 uses a 288-length string, so for posterity we follow that closely.
+ setBodyInnerHTML("<div id='target'>xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx"
+ "xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx"
+ "xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx"
+ "</div>");
+ // Width may vary by platform and we just want to make sure it's something roughly reasonable.
+ float width = getBasicText()->width(23u, 4294967282u, LayoutUnit(2.59375), RTL, false);
+ ASSERT_GE(width, 100.f);
+ ASSERT_LE(width, 300.f);
+}
+
+TEST_F(LayoutTextTest, WidthFromBeyondLength)
+{
+ setBasicBody("x");
+ ASSERT_EQ(0u, getBasicText()->width(1u, 1u, LayoutUnit(), LTR, false));
+}
+
+TEST_F(LayoutTextTest, WidthLengthBeyondLength)
+{
+ setBasicBody("x");
+ // Width may vary by platform and we just want to make sure it's something roughly reasonable.
+ float width = getBasicText()->width(0u, 2u, LayoutUnit(), LTR, false);
+ ASSERT_GE(width, 4.f);
+ ASSERT_LE(width, 20.f);
+}
+
+} // namespace blink
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutText.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698