Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 234563005: Fix for unable to enter decimal in number input field (Closed)

Created:
6 years, 8 months ago by AviD
Modified:
6 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fix for unable to enter decimal in number input field Steps: 1. Open google.com 2. Search for "Currency converter" 3. User unable to enter decimal values in number input field This issue is caused because InputType.TYPE_NUMBER_FLAG_DECIMAL was not being set for number input type. BUG=151738 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=264298

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 18 (0 generated)
AviD
PTAL
6 years, 8 months ago (2014-04-11 09:33:18 UTC) #1
AviD
Added more reviewers
6 years, 8 months ago (2014-04-11 09:43:26 UTC) #2
jdduke (slow)
Looks legit, good catch. Adding aurimas@ for approval.
6 years, 8 months ago (2014-04-11 15:18:02 UTC) #3
AviD
Hi Aurimas Please take a look at this CL Thanks Avinaash
6 years, 8 months ago (2014-04-16 16:13:23 UTC) #4
aurimas (slooooooooow)
LGTM, sorry for the delay!
6 years, 8 months ago (2014-04-16 17:03:51 UTC) #5
aurimas (slooooooooow)
The CQ bit was checked by aurimas@chromium.org
6 years, 8 months ago (2014-04-16 17:03:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi.nitk@samsung.com/234563005/1
6 years, 8 months ago (2014-04-16 17:04:54 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-16 18:13:49 UTC) #8
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=61801
6 years, 8 months ago (2014-04-16 18:13:51 UTC) #9
aurimas (slooooooooow)
The CQ bit was checked by aurimas@chromium.org
6 years, 8 months ago (2014-04-16 18:15:24 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi.nitk@samsung.com/234563005/1
6 years, 8 months ago (2014-04-16 18:15:35 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-16 18:47:11 UTC) #12
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=61831
6 years, 8 months ago (2014-04-16 18:47:11 UTC) #13
aurimas (slooooooooow)
jdduke: can you give OWNERS LGTM?
6 years, 8 months ago (2014-04-16 18:58:54 UTC) #14
jdduke (slow)
lgtm
6 years, 8 months ago (2014-04-16 18:59:53 UTC) #15
aurimas (slooooooooow)
The CQ bit was checked by aurimas@chromium.org
6 years, 8 months ago (2014-04-16 19:02:31 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi.nitk@samsung.com/234563005/1
6 years, 8 months ago (2014-04-16 19:02:57 UTC) #17
commit-bot: I haz the power
6 years, 8 months ago (2014-04-16 20:43:02 UTC) #18
Message was sent while issue was closed. 
Change committed as 264298

Powered by Google App Engine
This is Rietveld 408576698