Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 23456046: Implement unicode bidi P2 and P3 rules in BidiResolver (Closed)

Created:
7 years, 3 months ago by igoroliveira
Modified:
7 years, 3 months ago
CC:
blink-reviews, jamesr, loislo+blink_chromium.org, dsinclair, eae+blinkwatch, leviw+renderwatch, abarth-chromium, danakj, yurys+blink_chromium.org, dglazkov+blink, Rik, adamk+blink_chromium.org, jchaffraix+rendering, Stephen Chennney, jeez, pdr.
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

In blink we have two unicode bidi P2 and P3[1] rules implementations(One in RenderBlockLineLayout and other one in StringImpl). The purpose of this patch is moving those implementations to BidiResolver to avoid code duplication. [1] http://www.unicode.org/reports/tr9/#The_Paragraph_Level Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158245

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -56 lines) Patch
M Source/core/html/HTMLElement.cpp View 3 chunks +15 lines, -4 lines 0 comments Download
M Source/core/platform/graphics/TextRunIterator.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/platform/text/BidiResolver.h View 2 chunks +32 lines, -0 lines 0 comments Download
M Source/core/rendering/InlineIterator.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderBlockLineLayout.cpp View 1 chunk +2 lines, -18 lines 0 comments Download
M Source/wtf/text/StringImpl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/wtf/text/StringImpl.cpp View 1 chunk +0 lines, -20 lines 0 comments Download
M Source/wtf/text/WTFString.h View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
igoroliveira
7 years, 3 months ago (2013-09-23 22:19:12 UTC) #1
leviw_travelin_and_unemployed
This is great work! lgtm!
7 years, 3 months ago (2013-09-23 23:07:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/igor.o@sisa.samsung.com/23456046/1
7 years, 3 months ago (2013-09-24 00:30:42 UTC) #3
commit-bot: I haz the power
Retried try job too often on blink_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_presubmit&number=7409
7 years, 3 months ago (2013-09-24 00:57:55 UTC) #4
esprehn
What is a P2 or P3 rule?
7 years, 3 months ago (2013-09-24 03:37:18 UTC) #5
leviw_travelin_and_unemployed
Good point. It's from http://www.unicode.org/reports/tr9/ but it belongs in the description.
7 years, 3 months ago (2013-09-24 03:46:56 UTC) #6
leviw_travelin_and_unemployed
(Please update it as such before landing)
7 years, 3 months ago (2013-09-24 03:47:08 UTC) #7
leviw_travelin_and_unemployed
On 2013/09/24 03:47:08, Levi wrote: > (Please update it as such before landing) I see ...
7 years, 3 months ago (2013-09-24 04:04:54 UTC) #8
tkent
wtf LGTM. Please add a specification URL to the description.
7 years, 3 months ago (2013-09-24 04:05:35 UTC) #9
leviw_travelin_and_unemployed
That's the first "wtf LGTM" I've seen :)
7 years, 3 months ago (2013-09-24 04:11:13 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/igor.o@sisa.samsung.com/23456046/1
7 years, 3 months ago (2013-09-24 04:11:35 UTC) #11
commit-bot: I haz the power
7 years, 3 months ago (2013-09-24 05:58:15 UTC) #12
Message was sent while issue was closed.
Change committed as 158245

Powered by Google App Engine
This is Rietveld 408576698