[NaCl SDK] nacl_io: Add initial support for getsockopt

native_client_sdk/src/libraries/nacl_io/mount_node_socket.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "nacl_io/ossocket.h"
 #ifdef PROVIDES_SOCKET_API
 
 #include <errno.h>
 #include <string.h>
 #include <sys/fcntl.h>
@@ skipping 186 matching lines @@
 }
 
 Error MountNodeSocket::Listen(int backlog) {
   return EOPNOTSUPP;
 }
 
 Error MountNodeSocket::GetSockOpt(int lvl,
                                   int optname,
                                   void* optval,
                                   socklen_t* len) {
+  if (lvl != SOL_SOCKET)
+    return EINVAL;
+
+  switch (optname) {
+    case SO_ERROR:
+      if (*len < sizeof(int))

[binji, 2013/09/30 16:37:48]

http://pubs.opengroup.org/onlinepubs/009695399/functions/getsockopt.html

It says here that the value should be truncated if the size is too small: "If
the size of the option value is greater than option_len, the value stored in the
object pointed to by the option_value argument shall be silently truncated."

[Sam Clegg, 2013/09/30 17:33:25]

Done.

+        return EINVAL;
+      *static_cast<int*>(optval) = 0;

[binji, 2013/09/30 16:37:48]

always 0? This probably needs to be a virtual function so the TCP/UDP socket can
retrieve error if it has one and clear it. Or their error member variables
should move up here.

[Sam Clegg, 2013/09/30 17:33:25]

Done.

+      *len = sizeof(int);
+      return 0;
+  }
+
   return EINVAL;
 }
 
 Error MountNodeSocket::SetSockOpt(int lvl,
                                   int optname,
                                   const void* optval,
                                   socklen_t len) {
   return EINVAL;
 }
 
@@ skipping 148 matching lines @@
   if (local_addr_ != 0) {
     *len = ResourceToSockAddr(local_addr_, *len, addr);
     return 0;
   }
 
   return ENOTCONN;
 }
 
 }  // namespace nacl_io
 
-#endif  // PROVIDES_SOCKET_API
+#endif  // PROVIDES_SOCKET_API