[NaCl SDK] nacl_io: Add initial support for getsockopt

native_client_sdk/src/tests/nacl_io_socket_test/socket_test.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <arpa/inet.h>
 #include <errno.h>
 #include <fcntl.h>
 #include <netinet/in.h>
 #include <pthread.h>
 #include <sys/types.h>
@@ skipping 198 matching lines @@
 // TODO(noelallen) BUG=294412
 // Re-enable testing on bots when server sockets are available.
 TEST_F(SocketTestTCP, DISABLED_Connect) {
   char outbuf[256];
   char inbuf[512];
 
   memset(outbuf, 1, sizeof(outbuf));
   memset(inbuf, 0, sizeof(inbuf));
 
   int sock = socket(AF_INET, SOCK_STREAM, 0);
-  EXPECT_NE(-1, sock);
+  EXPECT_GT(sock, -1);
 
   sockaddr_in addr;
   socklen_t addrlen = sizeof(addr);
 
   IP4ToSockAddr(LOCAL_HOST, PORT1, &addr);
   int err = connect(sock, (sockaddr*) &addr, addrlen);
 
   EXPECT_EQ(ENONE, err) << "Failed with errno: " << errno << "\n";
 
   EXPECT_EQ(sizeof(outbuf), write(sock, outbuf, sizeof(outbuf)));
   EXPECT_EQ(sizeof(outbuf), read(sock, inbuf, sizeof(inbuf)));
 
   // Now they should be the same
   EXPECT_EQ(0, memcmp(outbuf, inbuf, sizeof(outbuf)));
 }
 
+TEST_F(SocketTest, Setsockopt) {
+  int sock = socket(AF_INET, SOCK_STREAM, 0);
+  EXPECT_GT(sock, -1);
+  int socket_error = 99;
+  socklen_t len = sizeof(socket_error);
+
+  // Test for valid option (SO_ERROR) which should be 0 when a socket
+  // is first created.
+  ASSERT_EQ(0, getsockopt(sock, SOL_SOCKET, SO_ERROR, &socket_error, &len));
+  ASSERT_EQ(0, socket_error);
+  ASSERT_EQ(sizeof(socket_error), len);
+
+  // Test for an invalid option (-1)
+  ASSERT_EQ(-1, getsockopt(sock, SOL_SOCKET, -1, &socket_error, &len));
+  ASSERT_EQ(ENOPROTOOPT, errno);
+}

[noelallen1, 2013/09/30 22:56:16]

Read an unbound socket, for a real Errno?

[Sam Clegg, 2013/10/01 00:15:49]

I'm mimicking the linux behavior and strangely enough, attempting
to read() on an non-bound/non-connected socket returns an error
but doesn't set SO_ERROR.

The behaviors seems to be that SO_ERROR is not set for calls that
return the error synchronously.  As if the stack thinks the error
has already been delivered to the user so it doesn't store it for
retrieval via SO_ERROR.

In summary I think we need to wait for the non-blocking connect()
to be able to test this case.

+
+TEST_F(SocketTest, Getsockopt) {
+  int sock = socket(AF_INET, SOCK_STREAM, 0);
+  EXPECT_GT(sock, -1);
+
+  // It should not be possible to set SO_ERROR using setsockopt.
+  int socket_error = 10;
+  socklen_t len = sizeof(socket_error);
+  ASSERT_EQ(-1, setsockopt(sock, SOL_SOCKET, SO_ERROR, &socket_error, len));
+  ASSERT_EQ(ENOPROTOOPT, errno);
+}
+
 #endif  // PROVIDES_SOCKET_API