Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 2345603002: Fix document mode migration again (Closed)

Created:
4 years, 3 months ago by Theresa
Modified:
4 years, 3 months ago
Reviewers:
gone
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Fix document mode migration again The document mode migration code was changed in 4804efe6387351c7802a2e9f34afe84e7ccbe7fe to skip document mode migration if a shared preference was not set. On older versions of Chrome, that shared preference wasn't set even though the user was in document mode. Migration was skipped and all tabs were lost. Revert to the old logic of using another shared preference to help determine if the user is in document mode. BUG=646146 TBR=dfalcantara@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -7 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/tabmodel/DocumentModeAssassin.java View 4 chunks +55 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
gone
4 years, 3 months ago (2016-09-14 23:04:56 UTC) #1
lgtm

Powered by Google App Engine
This is Rietveld 408576698