test/cctest/wasm/test-wasm-function-name-table.cc - Issue 2345593003: [wasm] Master CL for Binary 0xC changes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/wasm/test-wasm-function-name-table.cc

Issue 2345593003: [wasm] Master CL for Binary 0xC changes. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix test failures and TSAN races. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/cctest/wasm/test-wasm-function-name-table.cc

diff --git a/test/cctest/wasm/test-wasm-function-name-table.cc b/test/cctest/wasm/test-wasm-function-name-table.cc

index 1ae78dcb4e6d8322dc1efb06861bb1e92d49b537..9a4394204bf9f52d9650c8c8ec0a0ab90395dbe1 100644

--- a/test/cctest/wasm/test-wasm-function-name-table.cc

+++ b/test/cctest/wasm/test-wasm-function-name-table.cc

@@ -41,9 +41,9 @@ void testFunctionNameTable(Vector<Vector<const char>> names) {

name.start() + name.length());

// Make every second function name null-terminated.

if (func_index % 2) all_names.push_back('\0');

- module.functions.push_back({nullptr, 0, 0,

- static_cast<uint32_t>(name_offset),

- static_cast<uint32_t>(name.length()), 0, 0});

+ module.functions.push_back(

+ {nullptr, 0, 0, static_cast<uint32_t>(name_offset),

+ static_cast<uint32_t>(name.length()), 0, 0, false, false});

++func_index;

}