Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 2345583005: Add use counter for CSS zoom:reset and zoom:document. (Closed)

Created:
4 years, 3 months ago by Bret
Modified:
4 years, 3 months ago
Reviewers:
Mark P, Rick Byers
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, asvitkine+watch_chromium.org, darktears, blink-reviews, rwlbuis, Tab Atkins
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add use counter for CSS zoom:reset and zoom:document. In order to deprecate or remove these values we need to measure usage. BUG=642613 Committed: https://crrev.com/cffab1f32b8add2dbb2cfdc746b488526663b63b Cr-Commit-Position: refs/heads/master@{#419284}

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 1 1 chunk +8 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (11 generated)
Bret
4 years, 3 months ago (2016-09-16 01:35:24 UTC) #3
Rick Byers
LGTM
4 years, 3 months ago (2016-09-16 14:39:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2345583005/1
4 years, 3 months ago (2016-09-16 17:12:09 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/142979) chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
4 years, 3 months ago (2016-09-16 17:15:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2345583005/20001
4 years, 3 months ago (2016-09-16 19:54:14 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/261347)
4 years, 3 months ago (2016-09-16 20:04:16 UTC) #13
Bret
mpearson@: OWNERS for histogram.xml (I didn't realize it had different owners than UseCounter.h)
4 years, 3 months ago (2016-09-16 20:27:58 UTC) #15
Mark P
histograms.xml lgtm
4 years, 3 months ago (2016-09-16 20:28:27 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2345583005/20001
4 years, 3 months ago (2016-09-16 20:30:13 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-16 21:43:50 UTC) #20
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 21:46:58 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cffab1f32b8add2dbb2cfdc746b488526663b63b
Cr-Commit-Position: refs/heads/master@{#419284}

Powered by Google App Engine
This is Rietveld 408576698