Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Issue 2345583004: Add PageBoundaryRule parameter to fragmentainerGroupAtFlowThreadOffset(). (Closed)

Created:
4 years, 3 months ago by mstensho (USE GERRIT)
Modified:
4 years, 3 months ago
Reviewers:
eae
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews, mstensho (USE GERRIT)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add PageBoundaryRule parameter to fragmentainerGroupAtFlowThreadOffset(). If it's an exclusive end offset, we need to know this, so that we map to the former fragmentainer group, rather than the latter, if the offset is at a column row boundary. Committed: https://crrev.com/93d76ce0e06aefbb038efc84013adbdd82a61754 Cr-Commit-Position: refs/heads/master@{#418958}

Patch Set 1 #

Messages

Total messages: 12 (7 generated)
mstensho (USE GERRIT)
4 years, 3 months ago (2016-09-15 16:34:56 UTC) #4
eae
LGTM
4 years, 3 months ago (2016-09-15 16:43:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2345583004/1
4 years, 3 months ago (2016-09-15 20:35:35 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-15 20:41:47 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 20:45:05 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/93d76ce0e06aefbb038efc84013adbdd82a61754
Cr-Commit-Position: refs/heads/master@{#418958}

Powered by Google App Engine
This is Rietveld 408576698