Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 2345533002: [SVGDom] Expose intrinsic size info (Closed)

Created:
4 years, 3 months ago by f(malita)
Modified:
4 years, 3 months ago
CC:
reviews_skia.org, reed1
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

[SVGDom] Expose intrinsic size info * expose intrinsic size info on <svg> nodes. * tweak the SkSVGDOM constructor to no longer take an container size param, but instead default to intrinsic size * update clients to call SkSVGDOM::setContainerSize() explicitly, when needed R=robertphillips@google.com,stephana@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2345533002 Committed: https://skia.googlesource.com/skia/+/e1baa7c105dad0f301ce34e5d6d1aa329334ef8c

Patch Set 1 #

Patch Set 2 : cleanup #

Total comments: 2

Patch Set 3 : private intrinsicSize() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -16 lines) Patch
M bench/nanobench.cpp View 1 1 chunk +9 lines, -4 lines 0 comments Download
M dm/DMSrcSink.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M experimental/svg/model/SkSVGDOM.h View 1 2 1 chunk +7 lines, -3 lines 0 comments Download
M experimental/svg/model/SkSVGDOM.cpp View 2 chunks +23 lines, -6 lines 0 comments Download
M experimental/svg/model/SkSVGSVG.h View 2 chunks +4 lines, -0 lines 0 comments Download
M experimental/svg/model/SkSVGSVG.cpp View 1 chunk +12 lines, -0 lines 0 comments Download
M samplecode/SampleSVGFile.cpp View 1 chunk +4 lines, -1 line 0 comments Download
M samplecode/SampleSVGPong.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 15 (10 generated)
f(malita)
This is mainly to allow nanobench to raster at "native"/intrinsic SVG resolution (for Android asset ...
4 years, 3 months ago (2016-09-14 18:12:29 UTC) #2
robertphillips
lgtm https://codereview.chromium.org/2345533002/diff/20001/experimental/svg/model/SkSVGDOM.h File experimental/svg/model/SkSVGDOM.h (right): https://codereview.chromium.org/2345533002/diff/20001/experimental/svg/model/SkSVGDOM.h#newcode28 experimental/svg/model/SkSVGDOM.h:28: Should intrinsicSize be private?
4 years, 3 months ago (2016-09-14 18:34:54 UTC) #9
f(malita)
https://codereview.chromium.org/2345533002/diff/20001/experimental/svg/model/SkSVGDOM.h File experimental/svg/model/SkSVGDOM.h (right): https://codereview.chromium.org/2345533002/diff/20001/experimental/svg/model/SkSVGDOM.h#newcode28 experimental/svg/model/SkSVGDOM.h:28: On 2016/09/14 18:34:53, robertphillips wrote: > Should intrinsicSize be ...
4 years, 3 months ago (2016-09-14 18:40:05 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2345533002/40001
4 years, 3 months ago (2016-09-14 18:43:46 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 19:04:34 UTC) #15
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/e1baa7c105dad0f301ce34e5d6d1aa329334ef8c

Powered by Google App Engine
This is Rietveld 408576698