Issue 234553003: UI changes for Zoom Extension API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 234553003: UI changes for Zoom Extension API (Closed)

Created:
6 years, 8 months ago by paulmeyer

Modified:
6 years, 4 months ago

Reviewers:
Fady Samuel, not at google - send to devlin

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

UI changes for Zoom Extension API. If an extension initiates a zoom change using the new zoom extension API, that extension's icon will appear in the zoom bubble so that it is clear that that extension caused the zoom. https://drive.google.com/a/chromium.org/file/d/0B-vQVHYQYGnwam9lQ19oNTNWcjg/edit?usp=sharing This icon also has a tooltip that identifies the extension, and can be clicked on to see that extension on the extension page. BUG=30583

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+136 lines, -12 lines)			Patch
	M	chrome/browser/ui/views/location_bar/zoom_bubble_view.h	View		5 chunks	+37 lines, -1 line	0 comments	Download
	M	chrome/browser/ui/views/location_bar/zoom_bubble_view.cc	View		9 chunks	+99 lines, -11 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

UI changes moved out to this patch.

Expand Messages | Collapse Messages