Source/core/platform/graphics/GraphicsLayer.h - Issue 23455058: WIP: WebLayer::addAnimation should transfer the ownership of WebAnimation instance.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/platform/graphics/GraphicsLayer.h

Issue 23455058: WIP: WebLayer::addAnimation should transfer the ownership of WebAnimation instance. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Improve WebPassOwnPtr so that it is hard to make a mistake. Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/platform/graphics/GraphicsLayer.h

diff --git a/Source/core/platform/graphics/GraphicsLayer.h b/Source/core/platform/graphics/GraphicsLayer.h

index 3c6e09254c405623bc46c077b79536ccf0de6c46..6b34f964120478c6911a0dd3ff9bb48ca10cc330 100644

--- a/Source/core/platform/graphics/GraphicsLayer.h

+++ b/Source/core/platform/graphics/GraphicsLayer.h

@@ -225,7 +225,7 @@ public:

// Return true if the animation is handled by the compositing system. If this returns

// false, the animation will be run by AnimationController.

// These methods handle both transitions and keyframe animations.

- bool addAnimation(WebKit::WebAnimation*);

+ bool addAnimation(PassOwnPtr<WebKit::WebAnimation>);

void pauseAnimation(int animationId, double /*timeOffset*/);

void removeAnimation(int animationId);

« no previous file with comments | « no previous file | Source/core/platform/graphics/GraphicsLayer.cpp » ('j') | no next file with comments »