Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Side by Side Diff: public/platform/WebPassOwnPtr.h

Issue 23455058: WIP: WebLayer::addAnimation should transfer the ownership of WebAnimation instance. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Improve WebPassOwnPtr so that it is hard to make a mistake. Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « public/platform/WebLayer.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Intel Corporation. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
11 * notice, this list of conditions and the following disclaimer in the 11 * notice, this list of conditions and the following disclaimer in the
12 * documentation and/or other materials provided with the distribution. 12 * documentation and/or other materials provided with the distribution.
13 * 13 *
14 * THIS SOFTWARE IS PROVIDED BY APPLE AND ITS CONTRIBUTORS "AS IS" AND ANY 14 * THIS SOFTWARE IS PROVIDED BY APPLE AND ITS CONTRIBUTORS "AS IS" AND ANY
15 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED 15 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
16 * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE 16 * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
17 * DISCLAIMED. IN NO EVENT SHALL APPLE OR ITS CONTRIBUTORS BE LIABLE FOR ANY 17 * DISCLAIMED. IN NO EVENT SHALL APPLE OR ITS CONTRIBUTORS BE LIABLE FOR ANY
18 * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES 18 * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
19 * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; 19 * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
20 * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND 20 * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
21 * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 21 * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF 22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
23 * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 23 * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
24 */ 24 */
25 25
26 #ifndef WebPrivateOwnPtr_h 26 #ifndef WebPassOwnPtr_h
27 #define WebPrivateOwnPtr_h 27 #define WebPassOwnPtr_h
28 28
29 #include "WebCommon.h" 29 #include "WebCommon.h"
30 30
31 #if INSIDE_BLINK
32 #include "wtf/OwnPtr.h"
33 #include "wtf/PassOwnPtr.h"
34 #include "wtf/UnusedParam.h"
35 #endif
36
31 namespace WebKit { 37 namespace WebKit {
32 38
33 // This class is an implementation detail of the WebKit API. It exists 39 // It exists to help transfer the ownership of either OwnPtr or PassOwnPtr from Blink to Chromium.
34 // to help simplify the implementation of WebKit interfaces that merely 40 //
35 // wrap a pointer to a WebCore class. It's similar to WebPrivatePtr, but it 41 // A typical usage is as follows:
36 // wraps a naked pointer rather than a reference counted. 42 // in Blink side
37 // Note: you must call reset(0) on the implementation side in order to delete 43 // OwnPtr<WebAnimation> animation;
38 // the WebCore pointer. 44 // WebLayer layer;
45 // layer->addAnimation(animation);
46 //
47 // in Chromium side
48 // bool WebAnimation::addAnimation(WebPassOwnPtr<WebAnimation> pop_animation) {
49 // scoped_ptr<WebAnimation> animation(pop_animation.leakPtr());
50 // ...
51 // }
39 template <typename T> 52 template <typename T>
40 class WebPrivateOwnPtr { 53 class WebPassOwnPtr {
41 public: 54 public:
42 WebPrivateOwnPtr() : m_ptr(0) {} 55 WebPassOwnPtr() : m_ptr(0) { }
43 ~WebPrivateOwnPtr() { BLINK_ASSERT(!m_ptr); } 56 ~WebPassOwnPtr() { BLINK_ASSERT(!m_ptr); delete m_ptr; }
57 WebPassOwnPtr(const WebPassOwnPtr& o) : m_ptr(o.leakPtr()) { }
58
59 T* leakPtr() const
60 {
61 T* ptr = m_ptr;
62 m_ptr = 0;
63 return ptr;
64 }
44 65
45 #if INSIDE_BLINK 66 #if INSIDE_BLINK
46 explicit WebPrivateOwnPtr(T* ptr) 67 explicit WebPassOwnPtr(T* ptr)
47 : m_ptr(ptr) 68 : m_ptr(ptr)
48 { 69 {
70 COMPILE_ASSERT(sizeof(T) > 0, TypeMustBeComplete);
49 } 71 }
50 72
51 void reset(T* ptr) 73 template<typename U> WebPassOwnPtr(const PassOwnPtr<U>&);
52 {
53 delete m_ptr;
54 m_ptr = ptr;
55 }
56
57 T* get() const { return m_ptr; }
58
59 T* operator->() const
60 {
61 BLINK_ASSERT(m_ptr);
62 return m_ptr;
63 }
64 #endif // INSIDE_BLINK 74 #endif // INSIDE_BLINK
65 75
66 private: 76 private:
67 T* m_ptr; 77 WebPassOwnPtr& operator=(const WebPassOwnPtr&);
68 78
69 WebPrivateOwnPtr(const WebPrivateOwnPtr&); 79 mutable T* m_ptr;
70 void operator=(const WebPrivateOwnPtr&);
71 }; 80 };
72 81
82 #if INSIDE_BLINK
83 template<typename T> template<typename U> inline WebPassOwnPtr<T>::WebPassOwnPtr (const PassOwnPtr<U>& o)
84 : m_ptr(o.leakPtr())
85 {
86 using WTF::EnableIf;
87 using WTF::IsPointerConvertible;
88 EnsurePtrConvertibleArgDefn(U, T) typeChecker = true;
89 UNUSED_PARAM(typeChecker);
90 }
91 #endif
92
73 } // namespace WebKit 93 } // namespace WebKit
74 94
75 #endif 95 #endif
OLDNEW
« no previous file with comments | « public/platform/WebLayer.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698