tools/perf/benchmarks/sunspider.py - Issue 23455049: [telemetry] Make single-benchmark measurements protected and undiscoverable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/benchmarks/sunspider.py

Issue 23455049: [telemetry] Make single-benchmark measurements protected and undiscoverable. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Update discover unit tests. Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/benchmarks/sunspider.py

diff --git a/tools/perf/benchmarks/sunspider.py b/tools/perf/benchmarks/sunspider.py

index b1ef769ac2fb144128595f5dcdc0e29d4fd4fa4a..7295a7e9213d9d904fd83dbe5dd05996e6742cef 100644

--- a/tools/perf/benchmarks/sunspider.py

+++ b/tools/perf/benchmarks/sunspider.py

@@ -11,7 +11,7 @@ from telemetry.page import page_measurement

from telemetry.page import page_set

-class SunspiderMeasurement(page_measurement.PageMeasurement):

+class _SunspiderMeasurement(page_measurement.PageMeasurement):

def MeasurePage(self, _, tab, results):

tab.WaitForJavaScriptExpression(

'window.location.pathname.indexOf("results.html") >= 0'

@@ -37,7 +37,7 @@ class SunspiderMeasurement(page_measurement.PageMeasurement):

class Sunspider(test.Test):

"""Apple's SunSpider JavaScript benchmark."""

- test = SunspiderMeasurement

+ test = _SunspiderMeasurement

def CreatePageSet(self, options):

sunspider_dir = os.path.join(util.GetChromiumSrcDir(),

« no previous file with comments | « tools/perf/benchmarks/spaceport.py ('k') | tools/perf/measurements/blink_perf.js » ('j') | no next file with comments »