tools/perf/benchmarks/octane.py - Issue 23455049: [telemetry] Make single-benchmark measurements protected and undiscoverable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/benchmarks/octane.py

Issue 23455049: [telemetry] Make single-benchmark measurements protected and undiscoverable. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Update discover unit tests. Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/benchmarks/octane.py

diff --git a/tools/perf/benchmarks/octane.py b/tools/perf/benchmarks/octane.py

index 2862e6200da25ef92c1a430cd2008c48932479c9..91eb99f704fd4064e78ffe8cc0844fe9d31cffdf 100644

--- a/tools/perf/benchmarks/octane.py

+++ b/tools/perf/benchmarks/octane.py

@@ -10,7 +10,7 @@ from telemetry.page import page_measurement

from telemetry.page import page_set

-class OctaneMeasurement(page_measurement.PageMeasurement):

+class _OctaneMeasurement(page_measurement.PageMeasurement):

def MeasurePage(self, _, tab, results):

tab.WaitForJavaScriptExpression(

'completed && !document.getElementById("progress-bar-container")', 300)

@@ -41,7 +41,7 @@ JSON.stringify(results);

class Octane(test.Test):

"""Google's Octane JavaScript benchmark."""

- test = OctaneMeasurement

+ test = _OctaneMeasurement

def CreatePageSet(self, options):

octane_dir = os.path.join(util.GetChromiumSrcDir(), 'chrome', 'test',

« no previous file with comments | « tools/perf/benchmarks/kraken.py ('k') | tools/perf/benchmarks/pica.py » ('j') | no next file with comments »