tools/perf/benchmarks/jsgamebench.py - Issue 23455049: [telemetry] Make single-benchmark measurements protected and undiscoverable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/benchmarks/jsgamebench.py

Issue 23455049: [telemetry] Make single-benchmark measurements protected and undiscoverable. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Update discover unit tests. Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/benchmarks/jsgamebench.py

diff --git a/tools/perf/benchmarks/jsgamebench.py b/tools/perf/benchmarks/jsgamebench.py

index ef9d5bdd1a2ad0c3a0b747a675271d326a7d7be7..e872b55c9d8fc11cf11b2dcb3decf91ab2bb3e15 100644

--- a/tools/perf/benchmarks/jsgamebench.py

+++ b/tools/perf/benchmarks/jsgamebench.py

@@ -11,7 +11,7 @@ from telemetry.page import page_measurement

from telemetry.page import page_set

-class JsgamebenchMeasurement(page_measurement.PageMeasurement):

+class _JsgamebenchMeasurement(page_measurement.PageMeasurement):

def MeasurePage(self, _, tab, results):

tab.ExecuteJavaScript('UI.call({}, "perftest")')

tab.WaitForJavaScriptExpression(

@@ -23,7 +23,7 @@ class JsgamebenchMeasurement(page_measurement.PageMeasurement):

class Jsgamebench(test.Test):

"""Counts how many animating sprites can move around on the screen at once."""

- test = JsgamebenchMeasurement

+ test = _JsgamebenchMeasurement

def CreatePageSet(self, options):

return page_set.PageSet.FromDict({

« no previous file with comments | « tools/perf/benchmarks/html5gaming.py ('k') | tools/perf/benchmarks/kraken.py » ('j') | no next file with comments »