tools/perf/benchmarks/dom_perf.py - Issue 23455049: [telemetry] Make single-benchmark measurements protected and undiscoverable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/benchmarks/dom_perf.py

Issue 23455049: [telemetry] Make single-benchmark measurements protected and undiscoverable. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Update discover unit tests. Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/benchmarks/dom_perf.py

diff --git a/tools/perf/benchmarks/dom_perf.py b/tools/perf/benchmarks/dom_perf.py

index 66f9638bbbf2de10626aad7835e7800c5d448cb3..56aa59b043064ed8746d7a051f07b8b326b72af0 100644

--- a/tools/perf/benchmarks/dom_perf.py

+++ b/tools/perf/benchmarks/dom_perf.py

@@ -35,7 +35,7 @@ SCORE_UNIT = 'score (bigger is better)'

SCORE_TRACE_NAME = 'score'

-class DomPerfMeasurement(page_measurement.PageMeasurement):

+class _DomPerfMeasurement(page_measurement.PageMeasurement):

@property

def results_are_the_same_on_every_page(self):

return False

@@ -70,7 +70,7 @@ class DomPerf(test.Test):

The final score is computed as the geometric mean of the individual results.

Scores are not comparable across benchmark suite versions and higher scores

means better performance: Bigger is better!"""

- test = DomPerfMeasurement

+ test = _DomPerfMeasurement

def CreatePageSet(self, options):

dom_perf_dir = os.path.join(util.GetChromiumSrcDir(), 'data', 'dom_perf')

« no previous file with comments | « tools/perf/benchmarks/canvasmark.py ('k') | tools/perf/benchmarks/dromaeo.py » ('j') | no next file with comments »