InstantExtended: Send search URLs to renderers.

chrome/common/search_urls.cc

+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/common/search_urls.h"
+
+#include "content/public/common/url_constants.h"
+#include "url/gurl.h"
+
+namespace search {

[samarth, 2013/09/20 16:43:40]

I think we should consider moving all of the utility stuff in search.h to be
under search.

FYI, see
https://groups.google.com/a/chromium.org/forum/#!searchin/chromium-dev/namesp....
I didn't see a firm conclusion there, but I think for this case, this is fine.

[Jered, 2013/09/20 20:55:49]

I agree. I don't think the grab bag of functions exposed from search.h should go
into the global namespace, and "search" is a more meaningful grouping than
"chrome" for these functions. I prefer to take that on in a separate CL though.

+
+namespace {
+bool MatchesOrigin(const GURL& my_url, const GURL& other_url) {
+  return my_url.host() == other_url.host() &&
+         my_url.port() == other_url.port() &&
+         (my_url.scheme() == other_url.scheme() ||
+          (my_url.SchemeIs(content::kHttpsScheme) &&
+           other_url.SchemeIs(content::kHttpScheme)));
+}
+}  // namespace
+
+bool MatchesOriginAndPath(const GURL& my_url, const GURL& other_url) {

[samarth, 2013/09/20 16:43:40]

Unit test please.

[Jered, 2013/09/20 20:55:49]

Done.

+  return MatchesOrigin(my_url, other_url) && my_url.path() == other_url.path();
+}
+
+} // namespace search