Check if timeout has expired after processing each sample

Check if timeout has expired after processing each sample

To avoid long intervals between taking samples due to processing all accumulated samples at once, the samples are processed one by one and we check if the sampling interval has elapsed after each step rather than after processing all the samples in the queue.

This is a modified version of r16549 whith a fix for test flakiness. The test flakiness introduced by the previous version of this changed was fixed by changing return type of ProfilerEventsProcessor::ProcessOneSample from bool to enum with 3 options. In the main profiling loop we decide that the next code event should be processed when sample with a greater ordinal number is encountered. When processing remaining samples we shouldn't wait for more samples and if the samples queue is empty we just process next code event.

BUG=v8:2814, v8:2871
R=bmeurer@chromium.org, loislo@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=16564

[loislo, 2013-09-05 14:56:51]

https://codereview.chromium.org/23455036/diff/1/src/cpu-profiler.cc
File src/cpu-profiler.cc (right):

https://codereview.chromium.org/23455036/diff/1/src/cpu-profiler.cc#newcode119
src/cpu-profiler.cc:119: if (ticks_from_vm_buffer_.IsEmpty()) return
NoSamplesInQueue;
I'd move this statement to line 109

[yurys, 2013-09-05 15:00:03]

https://codereview.chromium.org/23455036/diff/1/src/cpu-profiler.cc
File src/cpu-profiler.cc (right):

https://codereview.chromium.org/23455036/diff/1/src/cpu-profiler.cc#newcode119
src/cpu-profiler.cc:119: if (ticks_from_vm_buffer_.IsEmpty()) return
NoSamplesInQueue;
On 2013/09/05 14:56:51, loislo wrote:
> I'd move this statement to line 109
Along with lines 117 and 118? Note that we need to check that both queues are
empty.

[loislo, 2013-09-05 15:05:18]

lgtm

[Benedikt Meurer, 2013-09-06 06:16:11]

LGTM.

[yurys, 2013-09-06 06:25:34]

Committed patchset #1 manually as r16564 (presubmit successful).