WebRTC: Add rtc_stats_unittests to the test suite

Add rtc_stats_unittests to the test suite

A new stats collection API is being added to the relatively
new webrtc/stats/ subdirectory. The new stats has a new test
binary, rtc_stats_unittests, which needs to run on the
webrtc trybots.

This has been tested in https://codereview.webrtc.org/2340443002/ which resulted in
this fix which has landed https://codereview.webrtc.org/2333343002/.


BUG=646838
Committed: https://chromium.googlesource.com/chromium/tools/build/+/e1d15cd7795cc1c5465983af8a49669242857107

[ehmaldonado_chromium, 2016-09-14 13:23:41]

Description was changed from

==========
stuff

BUG=
==========

to

==========
A new stats collection API is being added to the relatively new webrtc/stats/
subdirectory. The new stats has a new test binary, rtc_stats_unittests, which
needs to run on the webrtc trybots.

BUG=
==========

[ehmaldonado_chromium, 2016-09-14 13:25:38]

Description was changed from

==========
A new stats collection API is being added to the relatively new webrtc/stats/
subdirectory. The new stats has a new test binary, rtc_stats_unittests, which
needs to run on the webrtc trybots.

BUG=
==========

to

==========
Add rtc_stats_unittests to the test suite

A new stats collection API is being added to the relatively
new webrtc/stats/ subdirectory. The new stats has a new test
binary, rtc_stats_unittests, which needs to run on the
webrtc trybots.

BUG=646838
==========

[ehmaldonado_chromium, 2016-09-14 13:26:15]

ehmaldonado@chromium.org changed reviewers:
+ hbos@chromium.org, kjellander@chromium.org

[hbos_chromium, 2016-09-14 13:35:41]

https://codereview.chromium.org/2345503002/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/webrtc/api.py (right):

https://codereview.chromium.org/2345503002/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/webrtc/api.py:50: 'rtc_stats_unittests',
Hmm... We added the "//testing/android/native_test:native_test_native_code" deps
to the BUILD.gn file and that made the test work on Android, but gave up making
it work with GYP (in stats.gyp).

Perhaps we need to skip it for ANDROID_APK_TESTS, I'm not sure. Kjellander do
you remember?

[kjellander_chromium, 2016-09-15 07:11:46]

Deploying a new test binary is always high risk of breakage.
Have you tested it on all platforms?

The easiest way to do that is to bake all the tests of the new test binary into
another one that already runs at our trybots, and fire tryjobs for such a
(temporary) CL. Have you done that?

Then we can go ahead and add it like this. Only doing GN is fine (we should
actually start cleaning up everything inside 'include_tests' for GYP).

[hbos_chromium, 2016-09-15 07:38:57]

On 2016/09/15 07:11:46, kjellander_chromium wrote:
> Deploying a new test binary is always high risk of breakage.
> Have you tested it on all platforms?
> 
> The easiest way to do that is to bake all the tests of the new test binary
into
> another one that already runs at our trybots, and fire tryjobs for such a
> (temporary) CL. Have you done that?
> 
> Then we can go ahead and add it like this. Only doing GN is fine (we should
> actually start cleaning up everything inside 'include_tests' for GYP).

Yes, I did that here https://codereview.webrtc.org/2340443002/ which resulted in
this fix which has landed https://codereview.webrtc.org/2333343002/.

[kjellander_chromium, 2016-09-15 07:42:34]

On 2016/09/15 07:38:57, hbos_chromium wrote:
> On 2016/09/15 07:11:46, kjellander_chromium wrote:
> > Deploying a new test binary is always high risk of breakage.
> > Have you tested it on all platforms?
> > 
> > The easiest way to do that is to bake all the tests of the new test binary
> into
> > another one that already runs at our trybots, and fire tryjobs for such a
> > (temporary) CL. Have you done that?
> > 
> > Then we can go ahead and add it like this. Only doing GN is fine (we should
> > actually start cleaning up everything inside 'include_tests' for GYP).
> 
> Yes, I did that here https://codereview.webrtc.org/2340443002/ which resulted
in
> this fix which has landed https://codereview.webrtc.org/2333343002/.

Alright, that's great. Then let's deploy this before it breaks! lgtm

[ehmaldonado_chromium, 2016-09-15 07:46:41]

Description was changed from

==========
Add rtc_stats_unittests to the test suite

A new stats collection API is being added to the relatively
new webrtc/stats/ subdirectory. The new stats has a new test
binary, rtc_stats_unittests, which needs to run on the
webrtc trybots.

BUG=646838
==========

to

==========
Add rtc_stats_unittests to the test suite

A new stats collection API is being added to the relatively
new webrtc/stats/ subdirectory. The new stats has a new test
binary, rtc_stats_unittests, which needs to run on the
webrtc trybots.

This has been tested in https://codereview.webrtc.org/2340443002/ which resulted
in
this fix which has landed https://codereview.webrtc.org/2333343002/.


BUG=646838
==========

[ehmaldonado_chromium, 2016-09-15 07:46:51]

The CQ bit was checked by ehmaldonado@chromium.org

[commit-bot: I haz the power, 2016-09-15 07:46:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 07:51:00]

Description was changed from

==========
Add rtc_stats_unittests to the test suite

A new stats collection API is being added to the relatively
new webrtc/stats/ subdirectory. The new stats has a new test
binary, rtc_stats_unittests, which needs to run on the
webrtc trybots.

This has been tested in https://codereview.webrtc.org/2340443002/ which resulted
in
this fix which has landed https://codereview.webrtc.org/2333343002/.


BUG=646838
==========

to

==========
Add rtc_stats_unittests to the test suite

A new stats collection API is being added to the relatively
new webrtc/stats/ subdirectory. The new stats has a new test
binary, rtc_stats_unittests, which needs to run on the
webrtc trybots.

This has been tested in https://codereview.webrtc.org/2340443002/ which resulted
in
this fix which has landed https://codereview.webrtc.org/2333343002/.


BUG=646838

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/e1d15cd7795cc1c54659...
==========

[commit-bot: I haz the power, 2016-09-15 07:51:01]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/e1d15cd7795cc1c54659...

[hbos_chromium, 2016-09-15 08:08:28]

On 2016/09/15 07:51:01, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1) as
>
https://chromium.googlesource.com/chromium/tools/build/+/e1d15cd7795cc1c54659...

Now it is still listed in ANDROID_APK_TESTS :o I hope that still works for GYP?

[kjellander_chromium, 2016-09-15 08:13:38]

https://codereview.chromium.org/2345503002/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/webrtc/api.py (right):

https://codereview.chromium.org/2345503002/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/webrtc/api.py:50: 'rtc_stats_unittests',
On 2016/09/14 13:35:41, hbos_chromium wrote:
> Hmm... We added the "//testing/android/native_test:native_test_native_code"
deps
> to the BUILD.gn file and that made the test work on Android, but gave up
making
> it work with GYP (in stats.gyp).
> 
> Perhaps we need to skip it for ANDROID_APK_TESTS, I'm not sure. Kjellander do
> you remember?

This has nothing to do with GYP/GN. It's just a list of tests that should run on
the Android bots. So this should be fine as your other test CL added them to a
test that ran on Android bots.