Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Side by Side Diff: Source/core/loader/TextResourceDecoderBuilder.cpp

Issue 23455024: Move ownership of the TextResourceDecoder to DecodedDataDocumentParser (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebased Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/loader/DocumentWriter.cpp ('k') | Source/core/rendering/RenderText.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
77 // Set the hint encoding to the parent frame encoding only if 77 // Set the hint encoding to the parent frame encoding only if
78 // the parent and the current frames share the security origin. 78 // the parent and the current frames share the security origin.
79 // We impose this condition because somebody can make a child frameg63 79 // We impose this condition because somebody can make a child frameg63
80 // containing a carefully crafted html/javascript in one encoding 80 // containing a carefully crafted html/javascript in one encoding
81 // that can be mistaken for hintEncoding (or related encoding) by 81 // that can be mistaken for hintEncoding (or related encoding) by
82 // an auto detector. When interpreted in the latter, it could be 82 // an auto detector. When interpreted in the latter, it could be
83 // an attack vector. 83 // an attack vector.
84 // FIXME: This might be too cautious for non-7bit-encodings and 84 // FIXME: This might be too cautious for non-7bit-encodings and
85 // we may consider relaxing this later after testing. 85 // we may consider relaxing this later after testing.
86 if (frame && canReferToParentFrameEncoding(frame, parentFrame)) { 86 if (frame && canReferToParentFrameEncoding(frame, parentFrame)) {
87 decoder->setHintEncoding(parentFrame->document()->decoder()); 87 if (parentFrame->document()->encodingWasDetectedHeuristically())
88 decoder->setHintEncoding(parentFrame->document()->encoding());
89
88 if (m_encoding.isEmpty()) 90 if (m_encoding.isEmpty())
89 decoder->setEncoding(parentFrame->document()->inputEncoding(), TextR esourceDecoder::EncodingFromParentFrame); 91 decoder->setEncoding(parentFrame->document()->inputEncoding(), TextR esourceDecoder::EncodingFromParentFrame);
90 } 92 }
91 } 93 }
92 94
93 PassRefPtr<TextResourceDecoder> TextResourceDecoderBuilder::buildFor(Document* d ocument) 95 PassRefPtr<TextResourceDecoder> TextResourceDecoderBuilder::buildFor(Document* d ocument)
94 { 96 {
95 RefPtr<TextResourceDecoder> decoder = createDecoderInstance(document); 97 RefPtr<TextResourceDecoder> decoder = createDecoderInstance(document);
96 setupEncoding(decoder.get(), document); 98 setupEncoding(decoder.get(), document);
97 document->setDecoder(decoder);
98 return decoder.release(); 99 return decoder.release();
99 } 100 }
100 101
101 void TextResourceDecoderBuilder::clear() 102 void TextResourceDecoderBuilder::clear()
102 { 103 {
103 if (!m_encodingWasChosenByUser) 104 if (!m_encodingWasChosenByUser)
104 m_encoding = String(); 105 m_encoding = String();
105 } 106 }
106 107
107 } 108 }
OLDNEW
« no previous file with comments | « Source/core/loader/DocumentWriter.cpp ('k') | Source/core/rendering/RenderText.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698