Move ownership of the TextResourceDecoder to DecodedDataDocumentParser

Source/core/dom/DecodedDataDocumentParser.cpp

 /*
  * Copyright (C) 2010 Google, Inc. All Rights Reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 67 matching lines @@
     titleElement->setTextContent(correctlyDecodedTitle, IGNORE_EXCEPTION);
 }
 
 }
 
 DecodedDataDocumentParser::DecodedDataDocumentParser(Document* document)
     : DocumentParser(document)
 {
 }
 
+DecodedDataDocumentParser::~DecodedDataDocumentParser()
+{
+}
+
+void DecodedDataDocumentParser::setDecoder(PassRefPtr<TextResourceDecoder> decoder)
+{
+    m_decoder = decoder;
+}
+
 size_t DecodedDataDocumentParser::appendBytes(const char* data, size_t length)
 {
     if (!length)
         return 0;
 
     TitleEncodingFixer encodingFixer(document());
 
-    String decoded = document()->decoder()->decode(data, length);
-    document()->setEncoding(document()->decoder()->encoding());
+    String decoded = m_decoder->decode(data, length);
+    Document::DocumentEncodingData encodingData;
+    encodingData.encoding = m_decoder->encoding();
+    encodingData.wasDetectedHeuristically = m_decoder->encodingWasDetectedHeuristically();
+    encodingData.sawDecodingError = m_decoder->sawError();
+    document()->setEncoding(encodingData);

[abarth-chromium, 2013/08/30 22:50:38]

This happens for every call to appendBytes?  We can probably do better than
that.

 
     encodingFixer.fixTitleEncodingIfNeeded();
 
     if (decoded.isEmpty())
         return 0;
 
     size_t consumedChars = decoded.length();
     append(decoded.releaseImpl());
 
     return consumedChars;
 }
 
 size_t DecodedDataDocumentParser::flush()
 {
     // null decoder indicates there is no data received.
     // We have nothing to do in that case.
-    TextResourceDecoder* decoder = document()->decoder();
-    if (!decoder)
+    if (!m_decoder)
         return 0;
-    String remainingData = decoder->flush();
-    document()->setEncoding(document()->decoder()->encoding());
+    String remainingData = m_decoder->flush();
+    Document::DocumentEncodingData encodingData;
+    encodingData.encoding = m_decoder->encoding();
+    encodingData.wasDetectedHeuristically = m_decoder->encodingWasDetectedHeuristically();
+    encodingData.sawDecodingError = m_decoder->sawError();
+    document()->setEncoding(encodingData);

[abarth-chromium, 2013/08/30 22:50:38]

Copy/paste code makes me a sad panda.

+
     if (remainingData.isEmpty())
         return 0;
 
     size_t consumedChars = remainingData.length();
     append(remainingData.releaseImpl());
 
     return consumedChars;
 }
 
 };