Use exit command to stop web page replay server.

Use exit command to stop web page replay server.

On windows, web page replay server fails to do cleanup such as restoring dns settings if it gets terminated.

BUG=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220448

[chrisgao (Use stgao instead), 2013-08-27 16:35:53]

ptal

The corresponding change on web page replay is in CL
https://codereview.chromium.org/23469002/

[tonyg, 2013-08-28 01:46:34]

https://codereview.chromium.org/23455009/diff/2001/tools/telemetry/telemetry/...
File tools/telemetry/telemetry/core/wpr_server.py (right):

https://codereview.chromium.org/23455009/diff/2001/tools/telemetry/telemetry/...
tools/telemetry/telemetry/core/wpr_server.py:32: def StopServer(self):  #
pylint: disable=E1002
What lint error does this disable? Please remove if possible.

https://codereview.chromium.org/23455009/diff/2001/tools/telemetry/telemetry/...
tools/telemetry/telemetry/core/wpr_server.py:32: def StopServer(self):  #
pylint: disable=E1002
Shouldn't this whole method be in webpagereplay.py instead of here?

https://codereview.chromium.org/23455009/diff/2001/tools/telemetry/telemetry/...
tools/telemetry/telemetry/core/wpr_server.py:34: if self.replay_process:  #
pylint: disable=E0203
Ditto

[chrisgao (Use stgao instead), 2013-08-28 04:47:44]

ptal

https://codereview.chromium.org/23455009/diff/2001/tools/telemetry/telemetry/...
File tools/telemetry/telemetry/core/wpr_server.py (right):

https://codereview.chromium.org/23455009/diff/2001/tools/telemetry/telemetry/...
tools/telemetry/telemetry/core/wpr_server.py:32: def StopServer(self):  #
pylint: disable=E1002
On 2013/08/28 01:46:34, tonyg wrote:
> What lint error does this disable? Please remove if possible.

No warning after moved to webpagereplay.py

https://codereview.chromium.org/23455009/diff/2001/tools/telemetry/telemetry/...
tools/telemetry/telemetry/core/wpr_server.py:32: def StopServer(self):  #
pylint: disable=E1002
On 2013/08/28 01:46:34, tonyg wrote:
> Shouldn't this whole method be in webpagereplay.py instead of here?

Done.

https://codereview.chromium.org/23455009/diff/2001/tools/telemetry/telemetry/...
tools/telemetry/telemetry/core/wpr_server.py:34: if self.replay_process:  #
pylint: disable=E0203
On 2013/08/28 01:46:34, tonyg wrote:
> Ditto

No warning after moved to webpagereplay.py

[chrisgao (Use stgao instead), 2013-08-28 04:56:48]

https://codereview.chromium.org/23455009/diff/12001/DEPS
File DEPS (right):

https://codereview.chromium.org/23455009/diff/12001/DEPS#newcode236
DEPS:236: (Var("googlecode_url") % "web-page-replay") + "/trunk@520",
Will revert as https://codereview.chromium.org/23628003/ is in CQ.

[kkania, 2013-08-29 15:30:14]

https://codereview.chromium.org/23455009/diff/20001/chrome/test/functional/we...
File chrome/test/functional/webpagereplay.py (right):

https://codereview.chromium.org/23455009/diff/20001/chrome/test/functional/we...
chrome/test/functional/webpagereplay.py:197: # Use a SIGINT so that it can do
graceful cleanup.
would it be simpler at this point to just do a force kill instead of going
through another attempt at graceful cleanup?

[kkania, 2013-08-29 17:54:17]

lgtm

[chrisgao (Use stgao instead), 2013-08-29 20:54:26]

https://codereview.chromium.org/23455009/diff/20001/chrome/test/functional/we...
File chrome/test/functional/webpagereplay.py (right):

https://codereview.chromium.org/23455009/diff/20001/chrome/test/functional/we...
chrome/test/functional/webpagereplay.py:197: # Use a SIGINT so that it can do
graceful cleanup.
On 2013/08/29 15:30:14, kkania wrote:
> would it be simpler at this point to just do a force kill instead of going
> through another attempt at graceful cleanup?

As discussed offline, keep the current approach.

[commit-bot: I haz the power, 2013-08-29 20:55:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/chrisgao@chromium.org/23455009/25001

[commit-bot: I haz the power, 2013-08-30 00:24:24]

Change committed as 220448