Encoding API: Use 'windows-1252' as name for 'us-ascii' 'iso-8859-1'

Source/modules/encoding/TextDecoder.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 50 matching lines @@
     , m_fatal(fatal)
 {
 }
 
 TextDecoder::~TextDecoder()
 {
 }
 
 String TextDecoder::encoding() const
 {
-    return String(m_encoding.name()).lower();
+    String name = String(m_encoding.name()).lower();
+    // The same codec is used, but WTF maintains a different name/identity for these.
+    if (name == "iso-8859-1" || name == "us-ascii")

[jsbell, 2013/08/27 00:21:04]

This could also be done around line 44, during the construction. That would
ensure that even if Blink diverges from having these all use the same codec
class (TextCodecLatin1) they will still all use windows-1252. On the other hand,
aliasing here means we'd actually exercise WTF's aliasing, so I'm leaning
towards keeping it here.

[Ken Russell (switch to Gerrit), 2013/08/27 03:32:54]

I defer to your judgment. If the number of aliases grows large in the future, I
assume an actual data structure will be used.

+        return "windows-1252";
+    return name;
 }
 
 String TextDecoder::decode(ArrayBufferView* input, const Dictionary& options, ExceptionState& es)
 {
     bool stream = false;
     options.get("stream", stream);
 
     const char* start = input ? static_cast<const char*>(input->baseAddress()) : 0;
     size_t length = input ? input->byteLength() : 0;
 
     bool flush = !stream;
 
     // FIXME: Not all TextCodec implementations handle |flush| - notably TextCodecUTF16
     // ignores it and never flushes!
 
     bool sawError = false;
     String s = m_codec->decode(start, length, flush, m_fatal, sawError);
 
     if (m_fatal && sawError) {
         es.throwDOMException(EncodingError, "The encoded data was not valid.");
         return String();
     }
 
     return s;
 }
 
 } // namespace WebCore