Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(672)

Issue 2345463003: Revert "[Clock sync] Use clock sync manager to convert trace event timestamps" (Closed)

Created:
4 years, 3 months ago by charliea (OOO until 10-5)
Modified:
4 years, 3 months ago
CC:
catapult-reviews_chromium.org, tracing-review_chromium.org, nednguyen
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Revert "[Clock sync] Use clock sync manager to convert trace event timestamps" This reverts commit 260117fe0d2e76f878268a4c84e23ba0332e1329. TBR=oystein@chromium.org BUG=catapult:#646925 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/bb1d0fa5322f968b9db12cda686c17d4670fd2ee

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -136 lines) Patch
M tracing/tracing/extras/importer/trace_event_importer.html View 33 chunks +50 lines, -134 lines 0 comments Download
M tracing/tracing/extras/importer/trace_event_importer_test.html View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
charliea (OOO until 10-5)
4 years, 3 months ago (2016-09-14 21:03:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2345463003/1
4 years, 3 months ago (2016-09-14 21:13:10 UTC) #5
oystein (OOO til 10th of July)
lgtm
4 years, 3 months ago (2016-09-14 21:17:26 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/bb1d0fa5322f968b9db12cda686c17d4670fd2ee
4 years, 3 months ago (2016-09-14 21:34:41 UTC) #8
nednguyen
4 years, 3 months ago (2016-09-14 21:52:47 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2332213008/ by nednguyen@google.com.

The reason for reverting is: Revert this will break trace view on Android as
https://codereview.chromium.org/2301523007/ has landed..

Powered by Google App Engine
This is Rietveld 408576698