Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(608)

Issue 2345443002: FirstMeaningfulPaint UMA: Reduce the network activity threshold (Closed)

Created:
4 years, 3 months ago by Kunihiko Sakamoto
Modified:
4 years, 3 months ago
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, csharrison+watch_chromium.org, dshwang, loading-reviews+metrics_chromium.org, slimming-paint-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

FirstMeaningfulPaint UMA: Reduce the network activity threshold This patch changes the duration FirstMeaningfulPaintDetector waits before reporting FirstMeaningfulPaint from 2.0sec to 0.5sec. This is safe because only 0.18% of FirstMeaningfulPaint is in the range of [network stable - 2sec, network stable - 0.5sec]. BUG=632081 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/ffeb48f2494314b85493ad8fc0c54dbb1b4a44a1 Cr-Commit-Position: refs/heads/master@{#419638}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetector.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (11 generated)
Kunihiko Sakamoto
4 years, 3 months ago (2016-09-14 07:42:27 UTC) #7
kouhei (in TOK)
lgtm
4 years, 3 months ago (2016-09-14 10:36:32 UTC) #10
Bryan McQuade
lgtm
4 years, 3 months ago (2016-09-19 17:31:16 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2345443002/1
4 years, 3 months ago (2016-09-20 00:27:36 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-20 01:49:59 UTC) #15
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 01:51:23 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ffeb48f2494314b85493ad8fc0c54dbb1b4a44a1
Cr-Commit-Position: refs/heads/master@{#419638}

Powered by Google App Engine
This is Rietveld 408576698