|
|
DescriptionRemove Extensions.NetworkDelayStartup histogram
This histogram was added to the source in 2012, but never added to
histograms.xml. So noone ever looked at the data. Remove it.
Also add an obsolete entry to histograms.xml, so noone tries to reuse
the name.
BUG=643551
Committed: https://crrev.com/270969d1cb77d6314dfb0f4bea0d76f8a919eca4
Cr-Commit-Position: refs/heads/master@{#419102}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Remove owner tag from histograms.xml #
Messages
Total messages: 21 (12 generated)
The CQ bit was checked by ricea@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
ricea@chromium.org changed reviewers: + holte@chromium.org, rdevlin.cronin@chromium.org
+rdevlin for web_request_api.cc +holte for histograms.xml
lgtm with nit https://codereview.chromium.org/2345433002/diff/1/tools/metrics/histograms/hi... File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2345433002/diff/1/tools/metrics/histograms/hi... tools/metrics/histograms/histograms.xml:15963: + <owner>mpcomplete@chromium.org</owner> (in cl description) > mpcomplete@ has been marked as the owner of the histogram, but you should not ask him about it. This seems to nullify the point of owners. Additionally, I doubt anyone reading the histograms.xml file will ever read the CL that added it to find out that you shouldn't ask him about it. I'll let holte@ have final say, but I'd suggest not adding an owners tag for this (obsolete) histogram.
Description was changed from ========== Remove Extensions.NetworkDelayStartup histogram This histogram was added to the source in 2012, but never added to histograms.xml. So noone ever looked at the data. Remove it. Also add an obsolete entry to histograms.xml, so noone tries to reuse the name. The histogram was added by mpcomplete@chromium.org, who no longer works on Chrome. mpcomplete@ has been marked as the owner of the histogram, but you should not ask him about it. BUG=643551 ========== to ========== Remove Extensions.NetworkDelayStartup histogram This histogram was added to the source in 2012, but never added to histograms.xml. So noone ever looked at the data. Remove it. Also add an obsolete entry to histograms.xml, so noone tries to reuse the name. BUG=643551 ==========
https://codereview.chromium.org/2345433002/diff/1/tools/metrics/histograms/hi... File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2345433002/diff/1/tools/metrics/histograms/hi... tools/metrics/histograms/histograms.xml:15963: + <owner>mpcomplete@chromium.org</owner> On 2016/09/14 15:01:15, Devlin wrote: > (in cl description) > > mpcomplete@ has been marked as the owner of the histogram, > but you should not ask him about it. > > This seems to nullify the point of owners. Additionally, I doubt anyone reading > the histograms.xml file will ever read the CL that added it to find out that you > shouldn't ask him about it. I'll let holte@ have final say, but I'd suggest not > adding an owners tag for this (obsolete) histogram. I assumed that the <owner> tag was required. I have removed it.
lgtm
The CQ bit was checked by ricea@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from rdevlin.cronin@chromium.org Link to the patchset: https://codereview.chromium.org/2345433002/#ps20001 (title: "Remove owner tag from histograms.xml")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
The CQ bit was checked by ricea@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Remove Extensions.NetworkDelayStartup histogram This histogram was added to the source in 2012, but never added to histograms.xml. So noone ever looked at the data. Remove it. Also add an obsolete entry to histograms.xml, so noone tries to reuse the name. BUG=643551 ========== to ========== Remove Extensions.NetworkDelayStartup histogram This histogram was added to the source in 2012, but never added to histograms.xml. So noone ever looked at the data. Remove it. Also add an obsolete entry to histograms.xml, so noone tries to reuse the name. BUG=643551 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Remove Extensions.NetworkDelayStartup histogram This histogram was added to the source in 2012, but never added to histograms.xml. So noone ever looked at the data. Remove it. Also add an obsolete entry to histograms.xml, so noone tries to reuse the name. BUG=643551 ========== to ========== Remove Extensions.NetworkDelayStartup histogram This histogram was added to the source in 2012, but never added to histograms.xml. So noone ever looked at the data. Remove it. Also add an obsolete entry to histograms.xml, so noone tries to reuse the name. BUG=643551 Committed: https://crrev.com/270969d1cb77d6314dfb0f4bea0d76f8a919eca4 Cr-Commit-Position: refs/heads/master@{#419102} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/270969d1cb77d6314dfb0f4bea0d76f8a919eca4 Cr-Commit-Position: refs/heads/master@{#419102} |