Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(565)

Issue 2345433002: Remove Extensions.NetworkDelayStartup histogram (Closed)

Created:
4 years, 3 months ago by Adam Rice
Modified:
4 years, 3 months ago
Reviewers:
Devlin, Steven Holte
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, asvitkine+watch_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Extensions.NetworkDelayStartup histogram This histogram was added to the source in 2012, but never added to histograms.xml. So noone ever looked at the data. Remove it. Also add an obsolete entry to histograms.xml, so noone tries to reuse the name. BUG=643551 Committed: https://crrev.com/270969d1cb77d6314dfb0f4bea0d76f8a919eca4 Cr-Commit-Position: refs/heads/master@{#419102}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove owner tag from histograms.xml #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -6 lines) Patch
M extensions/browser/api/web_request/web_request_api.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (12 generated)
Adam Rice
+rdevlin for web_request_api.cc +holte for histograms.xml
4 years, 3 months ago (2016-09-14 07:54:25 UTC) #6
Devlin
lgtm with nit https://codereview.chromium.org/2345433002/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2345433002/diff/1/tools/metrics/histograms/histograms.xml#newcode15963 tools/metrics/histograms/histograms.xml:15963: + <owner>mpcomplete@chromium.org</owner> (in cl description) > ...
4 years, 3 months ago (2016-09-14 15:01:15 UTC) #7
Adam Rice
https://codereview.chromium.org/2345433002/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2345433002/diff/1/tools/metrics/histograms/histograms.xml#newcode15963 tools/metrics/histograms/histograms.xml:15963: + <owner>mpcomplete@chromium.org</owner> On 2016/09/14 15:01:15, Devlin wrote: > (in ...
4 years, 3 months ago (2016-09-15 01:27:20 UTC) #9
Steven Holte
lgtm
4 years, 3 months ago (2016-09-15 19:42:36 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2345433002/20001
4 years, 3 months ago (2016-09-16 01:03:12 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_chromium_compile_only_ng/builds/201055)
4 years, 3 months ago (2016-09-16 01:13:28 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2345433002/20001
4 years, 3 months ago (2016-09-16 03:55:11 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-16 04:33:34 UTC) #19
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 04:35:16 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/270969d1cb77d6314dfb0f4bea0d76f8a919eca4
Cr-Commit-Position: refs/heads/master@{#419102}

Powered by Google App Engine
This is Rietveld 408576698