Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 2345423002: Remove CanvasSurfaceLayerBridgeClient (Closed)

Created:
4 years, 3 months ago by dcheng
Modified:
4 years, 2 months ago
Reviewers:
Justin Novosad
CC:
chromium-reviews, krit, dshwang, drott+blinkwatch_chromium.org, ajuma+watch-canvas_chromium.org, blink-reviews-html_chromium.org, pdr+graphicswatchlist_chromium.org, jbroman, blink-reviews-platform-graphics_chromium.org, dglazkov+blink, Rik, f(malita), blink-reviews, danakj+watch_chromium.org, ajuma+watch_chromium.org, Stephen Chennney, rwlbuis, xlai (Olivia), danakj
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove CanvasSurfaceLayerBridgeClient This was an abstraction so that tests could substitute in a fake version of a Mojo interface in tests. However, the test can just implement a testing version of the Mojo interface and use it directly, simplifying the code. BUG=none Committed: https://crrev.com/69b35e1bfb4d055e99f94e9f2d749d728738586a Cr-Commit-Position: refs/heads/master@{#420583}

Patch Set 1 #

Patch Set 2 : Still hangs but simpler #

Patch Set 3 : Add a bunch of glue and it still doesn't work #

Patch Set 4 : New verison, remove unnecessary RunAllTests changes #

Patch Set 5 : Revert one more thing #

Messages

Total messages: 14 (9 generated)
dcheng
Note that this depends on https://codereview.chromium.org/2358133002/, otherwise, the test will fail on component builds.
4 years, 2 months ago (2016-09-22 17:44:37 UTC) #7
Justin Novosad
sweet. lgtm
4 years, 2 months ago (2016-09-22 21:50:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2345423002/80001
4 years, 2 months ago (2016-09-23 04:08:25 UTC) #10
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 2 months ago (2016-09-23 05:40:14 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-09-23 05:42:45 UTC) #14
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/69b35e1bfb4d055e99f94e9f2d749d728738586a
Cr-Commit-Position: refs/heads/master@{#420583}

Powered by Google App Engine
This is Rietveld 408576698