detect web-fonts, and force gray-antialiasing for them, regardless of the system's FONTSMOOTHING se…

detect web-fonts, and force gray-antialiasing for them, regardless of the system's FONTSMOOTHING setting

BUG=

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157775

[f(malita), 2013-09-13 15:28:02]

lgtm

https://codereview.chromium.org/23454039/diff/1/Source/core/platform/graphics...
File Source/core/platform/graphics/chromium/FontPlatformDataChromiumWin.cpp
(right):

https://codereview.chromium.org/23454039/diff/1/Source/core/platform/graphics...
Source/core/platform/graphics/chromium/FontPlatformDataChromiumWin.cpp:90: // 2.
the last two characters are '=='
Don't know much about LOGFONT, but I assume lfFaceName's storage is guaranteed
>= 25 chars? A quick search seems to confirm it.

[Stephen White, 2013-09-13 15:43:35]

On 2013/09/13 15:28:02, Florin Malita wrote:
> lgtm
> 
>
https://codereview.chromium.org/23454039/diff/1/Source/core/platform/graphics...
> File Source/core/platform/graphics/chromium/FontPlatformDataChromiumWin.cpp
> (right):
> 
>
https://codereview.chromium.org/23454039/diff/1/Source/core/platform/graphics...
> Source/core/platform/graphics/chromium/FontPlatformDataChromiumWin.cpp:90: //
2.
> the last two characters are '=='
> Don't know much about LOGFONT, but I assume lfFaceName's storage is guaranteed
> >= 25 chars? A quick search seems to confirm it.

I wondered the same thing. Looks like it's 32.

[commit-bot: I haz the power, 2013-09-13 18:52:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/reed@google.com/23454039/1

[commit-bot: I haz the power, 2013-09-13 19:48:05]

Change committed as 157775

[denny2006, 2013-09-19 06:56:01]

On 2013/09/13 19:48:05, I haz the power (commit-bot) wrote:
> Change committed as 157775

This is probably the worst possible solution.

I understand that I'm in the minority here and most people are happily browsing
with full AA switched on system-wide without even thinking about possible
eyesight effects blurry fonts may have. The problem is that  I decided to
disable AA system-wide I did it for a good reason. Therefore, I want a
web-browser to respect this choice or at the very least allow me to disable this
hack with a property (on the about://flags page). 

Without that I will have to resort to enforcing my predefined fonts on all
web-pages and I would prefer not to do that. Besides, with this hack, Chrome
becomes just another browser that ignores the settings.

[davidvielhuber, 2013-09-28 08:59:05]

where can I test this patch?
I use google chrome canary 23.0.1653.0 Aura but it seems that nothing has
changed.