third_party/WebKit/Source/core/paint/PaintPropertyTreePrinter.cpp - Issue 2345403003: Add background attachment fixed main thread scrolling reason [spv2]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/PaintPropertyTreePrinter.cpp

Issue 2345403003: Add background attachment fixed main thread scrolling reason [spv2] (Closed)

Patch Set: Update test that was written for PaintArtifactCompositor's reasons update Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/paint/PaintPropertyTreePrinter.cpp

diff --git a/third_party/WebKit/Source/core/paint/PaintPropertyTreePrinter.cpp b/third_party/WebKit/Source/core/paint/PaintPropertyTreePrinter.cpp

index c2ca62fd5bb9f30b4fc5211f80474a1aaba47516..99ba3fb359bac352379d706d4f28c2bd7e2439b2 100644

--- a/third_party/WebKit/Source/core/paint/PaintPropertyTreePrinter.cpp

+++ b/third_party/WebKit/Source/core/paint/PaintPropertyTreePrinter.cpp

@@ -220,6 +220,8 @@ public:

stringBuilder.append(node->userScrollableHorizontal() ? "yes" : "no");

stringBuilder.append(" userScrollableVertical=");

stringBuilder.append(node->userScrollableVertical() ? "yes" : "no");

+ stringBuilder.append(" hasBackgroundAttachmentFixedMainThreadScrollingReason=");

+ stringBuilder.append(node->hasMainThreadScrollingReasons(MainThreadScrollingReason::kHasBackgroundAttachmentFixedObjects) ? "yes" : "no");

}

};