third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp - Issue 2345403003: Add background attachment fixed main thread scrolling reason [spv2]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp

Issue 2345403003: Add background attachment fixed main thread scrolling reason [spv2] (Closed)

Patch Set: Minor cleanup Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp ('K') | « third_party/WebKit/Source/core/paint/PaintPropertyTreePrinter.cpp ('k') | third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp » ('j') | third_party/WebKit/Source/platform/graphics/paint/ScrollPaintPropertyNode.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp b/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp

index 79321fb3ed5ece415829117039910ffd6c52f24a..3d47b0f3441f5865284a29b0277b69fe57f6b036 100644

--- a/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp

+++ b/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp

@@ -372,12 +372,12 @@ int PropertyTreeManager::compositorIdForScrollNode(const ScrollPaintPropertyNode

compositorNode.scrollable = true;

- // TODO(pdr): Set main thread scrolling reasons.

compositorNode.scroll_clip_layer_bounds.SetSize(scrollNode->clip().width(), scrollNode->clip().height());

compositorNode.bounds.SetSize(scrollNode->bounds().width(), scrollNode->bounds().height());

compositorNode.user_scrollable_horizontal = scrollNode->userScrollableHorizontal();

compositorNode.user_scrollable_vertical = scrollNode->userScrollableVertical();

compositorNode.transform_id = compositorIdForTransformNode(scrollNode->scrollOffsetTranslation());

+ compositorNode.main_thread_scrolling_reasons = scrollNode->mainThreadScrollingReasons();

auto result = m_scrollNodeMap.set(scrollNode, id);

DCHECK(result.isNewEntry);