Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Side by Side Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 2345403003: Add background attachment fixed main thread scrolling reason [spv2] (Closed)
Patch Set: Update test that was written for PaintArtifactCompositor's reasons update Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutObject.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999 Lars Knoll <knoll@kde.org> 3 * 1999 Lars Knoll <knoll@kde.org>
4 * 1999 Antti Koivisto <koivisto@kde.org> 4 * 1999 Antti Koivisto <koivisto@kde.org>
5 * 2000 Dirk Mueller <mueller@kde.org> 5 * 2000 Dirk Mueller <mueller@kde.org>
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com) 7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com)
8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
9 * Copyright (C) 2009 Google Inc. All rights reserved. 9 * Copyright (C) 2009 Google Inc. All rights reserved.
10 * 10 *
(...skipping 1331 matching lines...) Expand 10 before | Expand all | Expand 10 after
1342 return !layoutViewItem.isNull() && layoutViewItem.compositingState() == Pain tsIntoOwnBacking; 1342 return !layoutViewItem.isNull() && layoutViewItem.compositingState() == Pain tsIntoOwnBacking;
1343 } 1343 }
1344 1344
1345 void FrameView::addBackgroundAttachmentFixedObject(LayoutObject* object) 1345 void FrameView::addBackgroundAttachmentFixedObject(LayoutObject* object)
1346 { 1346 {
1347 ASSERT(!m_backgroundAttachmentFixedObjects.contains(object)); 1347 ASSERT(!m_backgroundAttachmentFixedObjects.contains(object));
1348 1348
1349 m_backgroundAttachmentFixedObjects.add(object); 1349 m_backgroundAttachmentFixedObjects.add(object);
1350 if (ScrollingCoordinator* scrollingCoordinator = this->scrollingCoordinator( )) 1350 if (ScrollingCoordinator* scrollingCoordinator = this->scrollingCoordinator( ))
1351 scrollingCoordinator->frameViewHasBackgroundAttachmentFixedObjectsDidCha nge(this); 1351 scrollingCoordinator->frameViewHasBackgroundAttachmentFixedObjectsDidCha nge(this);
1352
1353 // TODO(pdr): When slimming paint v2 is enabled, invalidate the scroll paint
1354 // property subtree for this so main thread scroll reasons are recomputed.
1352 } 1355 }
1353 1356
1354 void FrameView::removeBackgroundAttachmentFixedObject(LayoutObject* object) 1357 void FrameView::removeBackgroundAttachmentFixedObject(LayoutObject* object)
1355 { 1358 {
1356 ASSERT(m_backgroundAttachmentFixedObjects.contains(object)); 1359 ASSERT(m_backgroundAttachmentFixedObjects.contains(object));
1357 1360
1358 m_backgroundAttachmentFixedObjects.remove(object); 1361 m_backgroundAttachmentFixedObjects.remove(object);
1359 if (ScrollingCoordinator* scrollingCoordinator = this->scrollingCoordinator( )) 1362 if (ScrollingCoordinator* scrollingCoordinator = this->scrollingCoordinator( ))
1360 scrollingCoordinator->frameViewHasBackgroundAttachmentFixedObjectsDidCha nge(this); 1363 scrollingCoordinator->frameViewHasBackgroundAttachmentFixedObjectsDidCha nge(this);
1364
1365 // TODO(pdr): When slimming paint v2 is enabled, invalidate the scroll paint
1366 // property subtree for this so main thread scroll reasons are recomputed.
1361 } 1367 }
1362 1368
1363 void FrameView::addViewportConstrainedObject(LayoutObject* object) 1369 void FrameView::addViewportConstrainedObject(LayoutObject* object)
1364 { 1370 {
1365 if (!m_viewportConstrainedObjects) 1371 if (!m_viewportConstrainedObjects)
1366 m_viewportConstrainedObjects = wrapUnique(new ViewportConstrainedObjectS et); 1372 m_viewportConstrainedObjects = wrapUnique(new ViewportConstrainedObjectS et);
1367 1373
1368 if (!m_viewportConstrainedObjects->contains(object)) { 1374 if (!m_viewportConstrainedObjects->contains(object)) {
1369 m_viewportConstrainedObjects->add(object); 1375 m_viewportConstrainedObjects->add(object);
1370 1376
(...skipping 3024 matching lines...) Expand 10 before | Expand all | Expand 10 after
4395 } 4401 }
4396 4402
4397 bool FrameView::canThrottleRendering() const 4403 bool FrameView::canThrottleRendering() const
4398 { 4404 {
4399 if (!RuntimeEnabledFeatures::renderingPipelineThrottlingEnabled()) 4405 if (!RuntimeEnabledFeatures::renderingPipelineThrottlingEnabled())
4400 return false; 4406 return false;
4401 return m_subtreeThrottled || (m_hiddenForThrottling && m_crossOriginForThrot tling); 4407 return m_subtreeThrottled || (m_hiddenForThrottling && m_crossOriginForThrot tling);
4402 } 4408 }
4403 4409
4404 } // namespace blink 4410 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutObject.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698