Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Unified Diff: net/socket/tcp_server_socket.cc

Issue 23454010: POSIX only: Move client socket functionality from TCPClientSocket into TCPSocket. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/socket/tcp_client_socket_libevent.cc ('k') | net/socket/tcp_socket.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/socket/tcp_server_socket.cc
diff --git a/net/socket/tcp_server_socket.cc b/net/socket/tcp_server_socket.cc
index 63cb2cf8875c57bb6de906b8e9464c328565a02e..a25f73f6c6f2717d6af3c2ee6fa5cb4be2eca896 100644
--- a/net/socket/tcp_server_socket.cc
+++ b/net/socket/tcp_server_socket.cc
@@ -7,7 +7,6 @@
#include "base/bind.h"
#include "base/bind_helpers.h"
#include "base/logging.h"
-#include "build/build_config.h"
#include "net/base/net_errors.h"
#include "net/socket/tcp_client_socket.h"
@@ -88,27 +87,9 @@ int TCPServerSocket::ConvertAcceptedSocket(
if (result != OK)
return result;
- // TODO(yzshen): Once we switch TCPClientSocketLibevent to take a connected
- // TCPSocket object, we don't need to do platform-specific handling.
-#if defined(OS_WIN)
- scoped_ptr<TCPClientSocket> client_socket(new TCPClientSocket(
+ output_accepted_socket->reset(new TCPClientSocket(
temp_accepted_socket.Pass(), accepted_address_));
-#elif defined(OS_POSIX)
- scoped_ptr<TCPClientSocket> client_socket(new TCPClientSocket(
- AddressList(accepted_address_),
- temp_accepted_socket->net_log().net_log(),
- temp_accepted_socket->net_log().source()));
- int raw_socket = temp_accepted_socket->Release();
- result = client_socket->AdoptSocket(raw_socket);
- if (result != OK) {
- // |client_socket| won't take ownership of |raw_socket| on failure.
- // Therefore, we put it back into |temp_accepted_socket| to close it.
- temp_accepted_socket->Adopt(raw_socket);
- return result;
- }
-#endif
- *output_accepted_socket = client_socket.Pass();
return OK;
}
« no previous file with comments | « net/socket/tcp_client_socket_libevent.cc ('k') | net/socket/tcp_socket.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698