Implement experimental MP3 support for Media Source API.

media/filters/pipeline_integration_test.cc

Index: media/filters/pipeline_integration_test.cc
diff --git a/media/filters/pipeline_integration_test.cc b/media/filters/pipeline_integration_test.cc
index e79f631b72b307e4ab1f2b1d90e731425b020185..0ddd2b4aadbaaa42fa09ffe61944a6bc871001b6 100644
--- a/media/filters/pipeline_integration_test.cc
+++ b/media/filters/pipeline_integration_test.cc
@@ -11,6 +11,7 @@
 #include "build/build_config.h"
 #include "media/base/decoder_buffer.h"
 #include "media/base/media_keys.h"
+#include "media/base/media_switches.h"
 #include "media/base/test_data_util.h"
 #include "media/cdm/aes_decryptor.h"
 #include "media/filters/chunk_demuxer.h"
@@ -33,6 +34,7 @@ static const char kMP4Video[] = "video/mp4; codecs=\"avc1.4D4041\"";
 static const char kMP4Audio[] = "audio/mp4; codecs=\"mp4a.40.2\"";
 static const char kMP4AudioType[] = "audio/mp4";
 static const char kMP4VideoType[] = "video/mp4";
+static const char kMP3[] = "audio/mpeg";
 
 // Key used to encrypt test files.
 static const uint8 kSecretKey[] = {
@@ -285,12 +287,15 @@ class MockMediaSource {
 
   void DemuxerOpenedTask() {
     size_t semicolon = mimetype_.find(";");
-    std::string type = mimetype_.substr(0, semicolon);
-    size_t quote1 = mimetype_.find("\"");
-    size_t quote2 = mimetype_.find("\"", quote1 + 1);
-    std::string codecStr = mimetype_.substr(quote1 + 1, quote2 - quote1 - 1);
+    std::string type = mimetype_;
     std::vector<std::string> codecs;
-    Tokenize(codecStr, ",", &codecs);
+    if (semicolon != std::string::npos) {
+      type = mimetype_.substr(0, semicolon);
+      size_t quote1 = mimetype_.find("\"");
+      size_t quote2 = mimetype_.find("\"", quote1 + 1);

[scherkus (not reviewing), 2013/09/03 19:34:22]

I know this is moving code around, but is it possible for quote1 and/or quote2
to be std::string::npos?

are these strings checked/sanitized elsewhere?

[acolwell GONE FROM CHROMIUM, 2013/09/04 00:48:13]

Only if someone puts an invalid mimetype in mimetype constants above.
No. The assumption is that whoever created the mimetype constants above created
valid mimetypes.

I've made the code a little more robust and will fail hard if the assumptions
are violated.

+      std::string codecStr = mimetype_.substr(quote1 + 1, quote2 - quote1 - 1);

[scherkus (not reviewing), 2013/09/03 19:34:22]

s/codecStr/codec/ ? (should be unix_hacker style)

[acolwell GONE FROM CHROMIUM, 2013/09/04 00:48:13]

Done.

+      Tokenize(codecStr, ",", &codecs);
+    }
 
     CHECK_EQ(chunk_demuxer_->AddId(kSourceId, type, codecs), ChunkDemuxer::kOk);
     AppendData(initial_append_size_);
@@ -627,6 +632,16 @@ TEST_F(PipelineIntegrationTest,
 }
 
 #if defined(USE_PROPRIETARY_CODECS)
+TEST_F(PipelineIntegrationTest, MediaSource_MP3) {
+  MockMediaSource source("sfx.mp3", kMP3, kAppendWholeFile);
+  StartPipelineWithMediaSource(&source);
+  source.EndOfStream();
+
+  Play();
+
+  EXPECT_TRUE(WaitUntilOnEnded());
+}
+
 TEST_F(PipelineIntegrationTest, MediaSource_ConfigChange_MP4) {
   MockMediaSource source("bear-640x360-av_frag.mp4", kMP4, kAppendWholeFile);
   StartPipelineWithMediaSource(&source);