Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 2345343002: Improve ColorStopOptimizer safety (Closed)

Created:
4 years, 3 months ago by tomhudson
Modified:
4 years, 3 months ago
Reviewers:
Brian Osman
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Improve ColorStopOptimizer safety Could potentially access uninitialized memory. BUG=647481 R=brianosman@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2345343002 Committed: https://skia.googlesource.com/skia/+/54d9b6688d3f023c40726c0ea1ab2629e54ab306

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M src/effects/gradients/SkGradientShader.cpp View 1 chunk +8 lines, -8 lines 0 comments Download

Messages

Total messages: 15 (11 generated)
tomhudson
PTAL
4 years, 3 months ago (2016-09-16 20:24:24 UTC) #4
Brian Osman
lgtm
4 years, 3 months ago (2016-09-16 20:25:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2345343002/1
4 years, 3 months ago (2016-09-16 21:21:36 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 21:22:51 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/54d9b6688d3f023c40726c0ea1ab2629e54ab306

Powered by Google App Engine
This is Rietveld 408576698