Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 2345333002: mash: Avoid KeyboardDrivenEventRewriter::GetInstance crash. (Closed)

Created:
4 years, 3 months ago by msw
Modified:
4 years, 3 months ago
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org, achuithb
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mash: Avoid KeyboardDrivenEventRewriter::GetInstance crash. Avoid mash null dcheck/deref with --login-manager. BUG=647781, 647039 TEST=No crash running chrome --mash --login-manager R=alemate@chromium.org,xiyuan@chromium.org Committed: https://crrev.com/9ea2a739531edffad0859fdfd0a53f1f039026e4 Cr-Commit-Position: refs/heads/master@{#419399}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 16 (10 generated)
msw
Please take a look, thanks! alemate: chrome/browser/ui/webui/chromeos/login/ xiyuan: chrome/browser/chromeos/
4 years, 3 months ago (2016-09-16 20:00:27 UTC) #3
xiyuan
lgtm
4 years, 3 months ago (2016-09-16 20:09:01 UTC) #6
Alexander Alekseev
lgtm
4 years, 3 months ago (2016-09-18 09:49:51 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2345333002/1
4 years, 3 months ago (2016-09-18 14:22:01 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-18 14:58:57 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-09-18 15:00:17 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9ea2a739531edffad0859fdfd0a53f1f039026e4
Cr-Commit-Position: refs/heads/master@{#419399}

Powered by Google App Engine
This is Rietveld 408576698