Issue 234533003: Fix screenshot.py

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 234533003: Fix screenshot.py (Closed)

Created:
6 years, 8 months ago by cjhopman

Modified:
6 years, 8 months ago

Reviewers:
jbudorick

CC:
chromium-reviews, klundberg+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix screenshot.py build/android/screenshot.py was creating a DeviceUtils. Then grabbing it's old_interface (i.e. an AndroidCommands) and calling screenshot on that. That then called TakeScreenshot from build/android/pylib/screenshot.py passing itself. But build/android/pylib/screenshot.py expects a DeviceUtils, not an AndroidCommands. So wrap the AndroidCommands back into a DeviceUtils first. build/android/screenshot.py could probably just call into build/android/pylib/screenshot.py directly. TBR=jbudorick NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263157

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	build/android/pylib/android_commands.py	View		2 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/234533003/1

6 years, 8 months ago (2014-04-11 02:16:02 UTC) #4

Message was sent while issue was closed.

Change committed as 263157

Expand Messages | Collapse Messages